Conversation
grantkee
requested a deployment
to
merge-into-main
GitHub Actions
Waiting
grantkee
commented
Mar 10, 2026
Contributor
Author
There was a problem hiding this comment.
moved this code to a separate mod for readability
grantkee
commented
Mar 10, 2026
| /// 1. Sends a `RequestBatchesStream` request to negotiate | ||
| /// 2. If accepted, opens a stream with the request digest for correlation | ||
| /// 3. Reads and validates batches from the stream in real-time | ||
| async fn request_batches_from_peer( |
grantkee
commented
Mar 10, 2026
| /// - Detects duplicate batches | ||
| /// | ||
| /// SAFETY: this method times out if a batch fails to stream within time limit. | ||
| pub(crate) async fn read_and_validate_batches_with_timeout<S: AsyncRead + Unpin + Send>( |
grantkee
commented
Mar 10, 2026
| /// Helper method to digest missing batch request before initiating stream. | ||
| /// | ||
| /// The digest is used to detect duplicate requests from peers. | ||
| pub(crate) fn generate_batch_request_id(&self, batch_digests: &HashSet<BlockHash>) -> B256 { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP