Customized branch for use in LYNX (leave PR open, need not merge) #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
Collaborator
|
Hi @mohammadsaadraza , awesome to see how you're using GNPy. When you're ready to push small, incremental changes to GNPy, please consider using Gerrit since that's where the development is taking place. Since this looks like a long-term work-in-progress draft PR, I wonder if there's a technical reason for leaving it open. Does it make your workflow easier in some way? If not, I would prefer to close the PR since it doesn't appear that we (GNPy maintainers) can do much at this point. |
Author
|
Thank you Jan. The reason I requested that PR be left open is for the
convenience of someone else looking to use GNPy in a server/API environment.
Ofcourse it is still an opiniated customized version meant for LYNX, but i
guess it can help someone else as well.
And that this GNPy repo has more traffic than ours. Maybe in the future,
GNPy maintainer could officially release a separate version using this PR.
…On Thu, 19 Jan 2023, 02:54 Jan Kundrát, ***@***.***> wrote:
Hi @mohammadsaadraza <https://github.com/mohammadsaadraza> , awesome to
see how you're using GNPy. When you're ready to push small, incremental
changes to GNPy, please consider using Gerrit since that's where the
development is taking place.
Since this looks like a long-term work-in-progress draft PR, I wonder if
there's a technical reason for leaving it open. Does it make your workflow
easier in some way? If not, I would prefer to close the PR since it doesn't
appear that we (GNPy maintainers) can do much at this point.
—
Reply to this email directly, view it on GitHub
<#455 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHZPQ443YAEXWWVDPFRZT5TWTBRA7ANCNFSM6AAAAAASV2U5IU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes are as follows:
This is an opinionated customization specifically for LYNX and will probably include more changes as we need them. Any suggestions are welcome.