Skip to content

Conversation

@jeslat
Copy link
Contributor

@jeslat jeslat commented Jun 9, 2025

🥅 What's the goal?

Improve image rendering in reports.

I've changed the failures and recorded reports to render the images without issues:

  • Failures report:
    • I've split the logs and the screenshots into two different tables.
  • Recorded report:
    • I've changed the table to render a different thing if it's an image.

I've also included a link around the image to be able to see it bigger in a new tab.

🧪 How can I test this?

  • Failures report:
    image

  • Recorded report:
    image

@jeslat jeslat marked this pull request as ready for review June 9, 2025 14:20
@jeslat jeslat requested review from a team, dpastor and hjorrod and removed request for a team June 9, 2025 14:21
Copy link
Contributor

@dpastor dpastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@jeslat jeslat requested a review from yamal-alm June 10, 2025 12:34
@jeslat jeslat merged commit 7c4dc7a into main Jun 10, 2025
1 check passed
@jeslat jeslat deleted the improve-reports2 branch June 10, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants