Merged
Conversation
|
Check SPDX headers ✅ 24 files have valid headers. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new "dry-run" option to allow processing of markdown and configuration files without connecting to Confluence. Key changes include:
- Adding test cases for the "dry-run" option in unit tests.
- Fetching and converting the "dry-run" input in the main code.
- Updating action configuration, README documentation, and the changelog accordingly.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/specs/main.spec.ts | Added tests verifying the conversion of "dry-run" inputs. |
| src/main.ts | Introduced parsing of the "dry-run" option and integrated it into the configuration. |
| package.json | Bumped version and updated dependency to include dryRun support. |
| action.yml | Added input specification for "dry-run". |
| README.md | Documented the new "dry-run" option. |
| CHANGELOG.md | Logged the addition of the dry-run feature and dependency bump. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
README.md:193
- Consider clarifying the differences between 'dry-run' and 'confluence-dry-run' in the README to help users distinguish their behaviors.
| `dry-run` | Process markdown files without sending them to the `confluence-sync` library. Useful to early detection of possible errors in configuration, markdown files, etc. Note that, requests that would be made to Confluence won't be logged, use `confluence-dry-run` for that, which also connects to Confluence to calculate the requests to do | No | |
|
Check License Compliance ✅ There are 772 dependencies with allowed licenses.
Errors:
✅ Result: Valid licenses |
MiguelJMC7
previously approved these changes
Jun 10, 2025
ismtabo
previously approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dry-run option
Description
Added
dry-runoption, enabling to process the markdown files and configuration without connecting to Confluence.Changed
closes #47
Agreement
Please check the following boxes after you have read and understood each item.
In case this is your first contribution to this project, you will also have to add a comment with the following text: "I have read the CLA Document and I hereby sign the CLA", otherwise the PR status will fail and our bot will request you to add it. Once you have signed it in a PR, you will not have to sign it again for future contributions.