Skip to content

feat(skin): update design tokens from mistica-design #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bocanegra merged 12 commits into from
Nov 27, 2025
Merged

feat(skin): update design tokens from mistica-design #485

Bocanegra merged 12 commits into from
Nov 27, 2025

Conversation

@tuentisre
Copy link
Collaborator

@tuentisre tuentisre commented Nov 14, 2025

Automated changes by create-pull-request GitHub action

@tuentisre tuentisre requested review from a team, daniel-tid and idenjoe and removed request for a team November 14, 2025 10:23
@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

Screenshot tests report

✔️ All passing

@amegias amegias requested review from Bocanegra and amegias and removed request for idenjoe November 17, 2025 10:50
@Bocanegra
Copy link
Contributor

Bocanegra commented Nov 17, 2025 •
edited by github-actions bot
Loading

Record screenshots on PR comment: succeeded ✅
https://github.com/Telefonica/mistica-ios/actions/runs/19427419601

@Bocanegra Bocanegra requested a review from yceballost November 17, 2025 11:57
@amegias
Copy link
Contributor

amegias commented Nov 18, 2025

@yceballost selected buttons look weird (without background/border/...) are they ok?
A lot of tokens have been created, should we apply them somewhere?

@yceballost
Copy link
Contributor

yceballost commented Nov 18, 2025

@yceballost selected buttons look weird (without background/border/...) are they ok? A lot of tokens have been created, should we apply them somewhere?

yay, I was checking with @AnaMontes11 yesterday, we need to fix this

@amegias
Copy link
Contributor

amegias commented Nov 19, 2025

@yceballost selected buttons look weird (without background/border/...) are they ok? A lot of tokens have been created, should we apply them somewhere?

yay, I was checking with @AnaMontes11 yesterday, we need to fix this

Please, let us know when it's fixed since it blocks this PR for 25.13.
I think you are going to update mistica-design tokens and we will have to get the tokens again, right?
Does it affect Android (Telefonica/mistica-android#469)??? cc/ @bravoborja

@yceballost
Copy link
Contributor

yceballost commented Nov 20, 2025

@yceballost selected buttons look weird (without background/border/...) are they ok? A lot of tokens have been created, should we apply them somewhere?

yay, I was checking with @AnaMontes11 yesterday, we need to fix this

Please, let us know when it's fixed since it blocks this PR for 25.13. I think you are going to update mistica-design tokens and we will have to get the tokens again, right? Does it affect Android (Telefonica/mistica-android#469)??? cc/ @bravoborja

PR on going
Telefonica/mistica-design#2429

But I think the PR will not fix this Tests/MisticaTests/UI/__Snapshots__/ButtonTests/testRegularSizeWithSecondaryStyle.with-movistarNew-style.png

because I think this token using in the Button border is wrong., but we will see with the update

@Bocanegra Bocanegra force-pushed the import-design-tokens branch from ff36b21 to 70bad74 Compare November 21, 2025 12:09
@Bocanegra
Copy link
Contributor

Bocanegra commented Nov 21, 2025 •
edited by github-actions bot
Loading

Record screenshots on PR comment: failed ❌
https://github.com/Telefonica/mistica-ios/actions/runs/19570733524

@yceballost yceballost mentioned this pull request Nov 21, 2025
Merged
amegias
amegias requested changes Nov 21, 2025
View reviewed changes
@Bocanegra Bocanegra force-pushed the import-design-tokens branch from 49d803f to 5a8d4a9 Compare November 24, 2025 08:07
@Bocanegra Bocanegra marked this pull request as draft November 26, 2025 12:57
@Bocanegra Bocanegra force-pushed the import-design-tokens branch from 150b687 to 41d342b Compare November 26, 2025 13:47
@Bocanegra
Copy link
Contributor

Bocanegra commented Nov 26, 2025 •
edited by amegias
Loading

/record-screenshots

@amegias
Copy link
Contributor

amegias commented Nov 26, 2025 •
edited by github-actions bot
Loading

Record screenshots on PR comment: succeeded ✅
https://github.com/Telefonica/mistica-ios/actions/runs/19707698006

@Bocanegra Bocanegra marked this pull request as ready for review November 26, 2025 15:30
@Bocanegra Bocanegra force-pushed the import-design-tokens branch from 4f14879 to fbb8d06 Compare November 27, 2025 08:12
@Bocanegra
Copy link
Contributor

Bocanegra commented Nov 27, 2025 •
edited by github-actions bot
Loading

Record screenshots on PR comment: succeeded ✅
https://github.com/Telefonica/mistica-ios/actions/runs/19732182189

@Bocanegra Bocanegra merged commit 4019066 into main Nov 27, 2025
1 check passed
@Bocanegra Bocanegra deleted the import-design-tokens branch November 27, 2025 10:36
tuentisre pushed a commit that referenced this pull request Dec 2, 2025
@semantic-release-bot
chore(release): 36.5.0 [skip ci]
30a9374 
# [36.5.0](v36.4.0...v36.5.0) (2025-12-02)

### Features

* **Button:** Add linkBrand style ([#489](#489)) ([4c83ed3](4c83ed3))
* **skin:** update design tokens from mistica-design ([#485](#485)) ([4019066](4019066))
@tuentisre
Copy link
Collaborator Author

tuentisre commented Dec 2, 2025

🎉 This PR is included in version 36.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bocanegra Bocanegra Bocanegra approved these changes

@amegias amegias amegias approved these changes

@daniel-tid daniel-tid daniel-tid approved these changes

@yceballost yceballost Awaiting requested review from yceballost

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tuentisre @Bocanegra @amegias @yceballost @daniel-tid