Skip to content

Prevent adding default parameter prefix to TelemetryDeck-internal params #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jeehut merged 1 commit into from
Jan 31, 2025
Merged

Prevent adding default parameter prefix to TelemetryDeck-internal params #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Sources/TelemetryDeck/TelemetryDeck.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ public enum TelemetryDeck {
guard !configuration.swiftUIPreviewMode, !configuration.analyticsDisabled else { return }

let combinedSignalName = (configuration.defaultSignalPrefix ?? "") + signalName
let prefixedParameters = parameters.mapKeys { (configuration.defaultParameterPrefix ?? "") + $0 }
let prefixedParameters = parameters.mapKeys { parameter in
guard !parameter.hasPrefix("TelemetryDeck.") else { return parameter }
return (configuration.defaultParameterPrefix ?? "") + parameter
}

if configuration.reservedParameterWarningsEnabled {
// warn users about reserved keys to avoid unexpected behavior
Expand Down Expand Up @@ -137,7 +140,10 @@ public enum TelemetryDeck {
// make sure to not send any signals when run by Xcode via SwiftUI previews
guard !configuration.swiftUIPreviewMode, !configuration.analyticsDisabled else { return }

let prefixedDefaultParameters = configuration.defaultParameters().mapKeys { (configuration.defaultParameterPrefix ?? "") + $0 }
let prefixedDefaultParameters = configuration.defaultParameters().mapKeys { parameter in
guard !parameter.hasPrefix("TelemetryDeck.") else { return parameter }
return (configuration.defaultParameterPrefix ?? "") + parameter
}
let combinedParameters = prefixedDefaultParameters.merging(parameters) { $1 }

// check only default parameters
Expand Down