Avoid potential compilation errors in app extensions when using CocoaPods#229
Merged
Avoid potential compilation errors in app extensions when using CocoaPods#229
Conversation
winsmith
approved these changes
Feb 2, 2025
Contributor
winsmith
left a comment
winsmith
left a comment
There was a problem hiding this comment.
I love seeing all this progress
Jeehut
force-pushed
the
feature/app-extensions
branch
from
fe6fba1 to
3b9cf34
Compare
Contributor
Author
|
@winsmith Our customer reported that the solution did not work as Swift flags do not pass on to packaged added via CocoaPods (and that's the only place this issue happens). So I have reverted the addition of the flag and went for a simple runtime check, which seems to have worked to fix the issue. In addition to this fix, CocoaPods users have to set |
Jeehut
changed the title
Jeehut
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #226.
Note that there seems to be no built-in preprocessor macro or flag to check for app extensions, so I have documented how to easily setup one for app extension targets. I followed the naming scheme of Apple's own flags so this feels natural.
I have also added "rounding to milliseconds" to our new duration signal feature to be consistent with the Kotlin SDK.