Make DurationSignalTracker run in main thread rather than private one#239
Closed
Make DurationSignalTracker run in main thread rather than private one#239
Conversation
Contributor
Author
|
After seeing and testing this "fix", the author of #237 concluded that there was actually no issue after all with our implementation and that it's probably more resilient. So I'm closing this PR without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #237.
Note: Previously, we were blocking the main thread and waiting for a background thread to execute the code, which was an unnecessary thread switch that only added overhead without any added safety. This avoids that.