Back : Ajout des données vulnérabilités + commande de génération MVT#153
Merged
ludovicdmt merged 4 commits intodevfrom Mar 27, 2025
Merged
Back : Ajout des données vulnérabilités + commande de génération MVT#153ludovicdmt merged 4 commits intodevfrom
ludovicdmt merged 4 commits intodevfrom
Conversation
Marc-AntoineA
approved these changes
Mar 27, 2025
Contributor
Marc-AntoineA
left a comment
Marc-AntoineA
left a comment
There was a problem hiding this comment.
Il manque selon moi :
- une documentation sur l'Atlas de Vulnérabilité −> peut être un autre ticket prioritaire ;
- la manière dont on récupère les données −> ajouter au moins un petit commentaire dessus ;
En terme de découpage de ta PR, ça me semble adapté de mettre la création de la view django en même temps que le front.
Je pense qu'il y aura un sujet de refacto futur pour éviter de créer des nouveaux modèles (+ view, + front) à chaque layer. Ça serait bien auss d'avoir qqch d'un peu générique.
J'approuve en avance de quand tu auras répondu à mes commentaires.
| if geolevel == GeoLevel.TILE.value: | ||
| mdl = Tile | ||
| elif geolevel == GeoLevel.LCZ.value: | ||
| elif (geolevel == GeoLevel.LCZ.value) and (datatype == DataType.LCZ.value): |
Contributor
There was a problem hiding this comment.
Pas besoin des parenthèses.
back/iarbre_data/models.py
Outdated
|
|
||
|
|
||
| @receiver(pre_save, sender=Vulnerability) | ||
| def before_save_vulnerability(sender, instance, **kwargs): |
Contributor
There was a problem hiding this comment.
Est-ce que ce Signal ne pourrait pas être mutualisé/hérité entre toutes les classe concernées ?
| } | ||
|
|
||
|
|
||
| @receiver(pre_save, sender=Lcz) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presentation_courte_cartes_vulnerabilite.pdf