Merged
Conversation
…Sharp We don't use C#-specific types and the dependency on Microsoft.CodeAnalysis.CSharp prevented our source generator from working in Visual Basic projects.
github-actions
bot
added
area:ci
github-actions
bot
added
the
area:docs
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Buildvana.Sdk project after more than a year of inactivity, bringing all dependencies, GitHub actions, and toolchain versions up to date. The update also fixes a bug where additional assembly info generation failed on Visual Basic projects.
- Updates all package dependencies, GitHub actions, and .NET SDK versions
- Fixes Visual Basic project compatibility by switching from
Microsoft.CodeAnalysis.CSharptoMicrosoft.CodeAnalysis.Common - Updates minimum supported versions of Roslyn, Visual Studio, and .NET SDK
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Buildvana.Sdk/Sdk/PackageVersions.props | Updates package versions for JetBrains.Annotations, Microsoft.CodeAnalysis.PublicApiAnalyzers, Nerdbank.GitVersioning, and Tools.InnoSetup |
| src/Buildvana.Sdk.Tasks/Buildvana.Sdk.Tasks.csproj | Fixes casing inconsistency in PrivateAssets attribute |
| src/Buildvana.Sdk.SourceGenerators/Buildvana.Sdk.SourceGenerators.csproj | Replaces Microsoft.CodeAnalysis.CSharp with Microsoft.CodeAnalysis.Common for VB support |
| global.json | Updates .NET SDK version from 8.0.204 to 9.0.304 |
| build.cake | Updates Buildvana.Cake version and modernizes target execution |
| Directory.Packages.props | Updates Microsoft.Build and Microsoft.CodeAnalysis package versions |
| CHANGELOG.md | Documents version updates and VB project fix |
| .github/workflows/*.yml | Updates GitHub actions to newer versions |
| .github/labeler.yml | Updates YAML syntax formatting |
| .config/dotnet-tools.json | Updates tool versions for cake.tool, nbgv, and reportgenerator |
| Buildvana.Sdk.sln.DotSettings | Adds ReSharper naming rules and migration flags |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Work on non-.NET projects has caused this project to stall for more than a year.
This PR is an attempt at updating it, in order to resume work on it and other related projects.
Proposed changes
Microsoft.CodeAnalysis.CSharpin favor ofMicrosoft.CodeAnalysis.Common(we didn't use any C#-specific types in the source generator anyway).Types of changes
This pull request introduces the following types of changes:
docsdirectory) update.gitattributes,.gitignore)Breaking changes
This pull request introduces breaking changes:
Checklist
docsdirectory) only: