fix: OHOS PAGView autoPlay not working and setProgress not synced#1177
Open
wwwcg wants to merge 1 commit intoTencent-TDS:mainfrom
Open
fix: OHOS PAGView autoPlay not working and setProgress not synced#1177wwwcg wants to merge 1 commit intoTencent-TDS:mainfrom
wwwcg wants to merge 1 commit intoTencent-TDS:mainfrom
Conversation
- KRPAGView.ets: 拦截autoPlay属性并实现tryAutoPlay机制，对齐Android端行为 - KRPAGView.ets: call()方法补充setProgress处理，解析JSON参数调用controller - IKRPAGViewController: 接口新增setProgress(value: number)方法 - AppKRPAGAdapter: 示例适配器实现setProgress，委托PAGViewController
wwwcg
requested review from
elixxli,
iPel,
luoyibu and
zenipchen
as code owners
wwwcg
changed the title
elixxli
reviewed
Mar 26, 2026
|
|
||
| stop(): void; | ||
|
|
||
| setProgress(value: number): void; |
Collaborator
There was a problem hiding this comment.
接口新增方法 建议文档备注 方便业务SDK升级适配
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoPlayprop not taking effect on OHOS:KRPAGView.etsnow interceptsautoPlayinsetPropand implements atryAutoPlay()mechanism (aligned with Android behavior)setProgressnot synced to OHOS: addsetProgresshandling inKRPAGView.etscall()method, and addsetProgress(value: number)toIKRPAGViewControllerinterfaceTest plan
autoPlay(true)is setautoPlay(false)is setsetProgress(value)correctly updates playback progress on OHOSplay()/stop()method calls work as expected