Add SetCacheDir API to customize disk cache directory.#3194
Closed
Add SetCacheDir API to customize disk cache directory.#3194
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3194 +/- ##
=======================================
Coverage 76.97% 76.97%
=======================================
Files 413 413
Lines 21910 21930 +20
Branches 6291 6302 +11
=======================================
+ Hits 16865 16881 +16
- Misses 3819 3824 +5
+ Partials 1226 1225 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shlzxjp
reviewed
Jan 19, 2026
| auto cacheDir = Platform::Current()->getCacheDir(); | ||
| } | ||
|
|
||
| void DiskCache::checkInitialized() { |
Collaborator
There was a problem hiding this comment.
看了下checkInitialized方法应该没必要,缓存路径初始化的逻辑放在构造方法中就行,这样就不用每个函数调用前都需要去调用一下checkInitialized方法了,后续增加新的方法可能会漏了调用,增加维护成本。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SetCacheDir API to customize disk cache directory.