Skip to content

Conversation

@domchen
Copy link
Collaborator

@domchen domchen commented Jan 20, 2026

更新 tgfx 子模块至最新版本 b8251c0d,适配新的 GPU 绘制 API,支持实例化绘制功能。

Copilot AI review requested due to automatic review settings January 20, 2026 08:56
@domchen domchen closed this Jan 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the tgfx submodule to commit b8251c0d and adapts the codebase to accommodate breaking changes in the GPU rendering API that introduce support for instanced drawing.

Changes:

  • Updated tgfx dependency to version b8251c0d
  • Migrated vertex descriptor API to use buffer layouts array structure
  • Updated setVertexBuffer call to accept buffer index parameter
  • Changed draw method call to use explicit uint32_t cast for vertex count

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
DEPS Updates tgfx submodule commit hash to b8251c0d
src/rendering/filters/RuntimeFilter.cpp Adapts to new tgfx GPU API by updating vertex descriptor initialization, setVertexBuffer call signature, and draw method parameter type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.17%. Comparing base (ea3d023) to head (7380a63).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3224      +/-   ##
==========================================
- Coverage   77.21%   77.17%   -0.05%     
==========================================
  Files         413      413              
  Lines       21910    21910              
  Branches     6291     6292       +1     
==========================================
- Hits        16918    16908      -10     
- Misses       3802     3805       +3     
- Partials     1190     1197       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@domchen domchen deleted the feature/domchen_update_tgfx branch January 20, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants