Skip to content

Conversation

@illidanstormrange
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.97%. Comparing base (18befa6) to head (4cf3ce2).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/rendering/caches/DiskCache.cpp 28.57% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3225   +/-   ##
=======================================
  Coverage   76.97%   76.97%           
=======================================
  Files         413      413           
  Lines       21910    21922   +12     
  Branches     6291     6298    +7     
=======================================
+ Hits        16865    16875   +10     
- Misses       3819     3824    +5     
+ Partials     1226     1223    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


void DiskCache::setCacheDir(const std::string& dir) {
std::lock_guard<std::mutex> autoLock(locker);
customCacheDir = dir;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dir如果不存在,没看到自动创建的逻辑

@shlzxjp shlzxjp merged commit f958df5 into main Jan 20, 2026
9 checks passed
@shlzxjp shlzxjp deleted the feature/fengdyli_setCacheDir branch January 20, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants