[ohos] Fix font fallback crash by using new text module API on API14+ #3238
+57
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add API version check using deviceInfo.sdkApiVersion - For API14+: use new text.getSystemFontFullNamesByType() and text.getFontDescriptorByFullName() APIs - Fallback to legacy font.getUIFontConfig() API if new API fails or on lower API versions - Add null checks for fontConfig and fallbackGroups - Fix paths.concat() bug (missing assignment) Related: #3232
kevingpqi123
requested review from
Hparty,
domchen and
shlzxjp
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3238 +/- ##
==========================================
- Coverage 77.04% 77.02% -0.03%
==========================================
Files 413 413
Lines 21922 21922
Branches 6298 6298
==========================================
- Hits 16890 16885 -5
- Misses 3821 3825 +4
- Partials 1211 1212 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
domchen
reviewed
Jan 28, 2026
ohos/libpag/src/main/ets/PAGInit.ets
Outdated
| let fontDescriptor = await text.getFontDescriptorByFullName(fontName, text.SystemFontType.ALL); | ||
| if (fontDescriptor && fontDescriptor.path) { | ||
| paths.push(fontDescriptor.path); | ||
| } |
Collaborator
There was a problem hiding this comment.
性能优化建议：当前串行 await 每个字体描述符，系统字体较多时初始化会较慢。建议使用 Promise.all() 并行获取：
let descriptors = await Promise.all(fontNames.map(fontName =>
text.getFontDescriptorByFullName(fontName, text.SystemFontType.ALL)
));
let paths = descriptors
.filter(d => d && d.path)
.map(d => d.path);
ohos/libpag/src/main/ets/PAGInit.ets
Outdated
| try { | ||
| let fontNames: string[] = await text.getSystemFontFullNamesByType(text.SystemFontType.ALL); | ||
| if (fontNames && fontNames.length > 0) { | ||
| let paths = new Array<string>(); |
Collaborator
There was a problem hiding this comment.
代码简化建议：使用字面量初始化更简洁，如 let paths: string[] = [];
ohos/libpag/src/main/ets/PAGInit.ets
Outdated
| for (let fontName of fontNames) { | ||
| let fontDescriptor = await text.getFontDescriptorByFullName(fontName, text.SystemFontType.ALL); | ||
| if (fontDescriptor && fontDescriptor.path) { | ||
| paths.push(fontDescriptor.path); |
Collaborator
There was a problem hiding this comment.
潜在风险：同一字体路径可能被多次添加（如同一字体在不同 fallbackGroup 出现），建议考虑去重处理。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3232