fix(convolutiondepthwise): add group == 0 guard to prevent FPE - #6912
Open
beilzx wants to merge 1 commit into
Open
fix(convolutiondepthwise): add group == 0 guard to prevent FPE#6912beilzx wants to merge 1 commit into
beilzx wants to merge 1 commit into
Conversation
Summary: - The Vulkan backend already has the correct `group == 0 || num_output % group != 0` check. - CPU backend (convolutiondepthwise.cpp:46) and 1D variant (convolutiondepthwise1d.cpp:40) are missing the `group == 0` guard. - When a malicious param file stores group as an array type, `pd.get(7, 1)` returns 0, triggering integer divide-by-zero. Verification: - Built ncnn with AddressSanitizer (`-fsanitize=address`). - Reproduced FPE with the AFL++ generated crash sample. - Confirmed the patch gracefully rejects the invalid param with `layer load_param failed` instead of crashing. Fixes Tencent#6911
Member
|
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
group == 0 || num_output % group != 0check.group == 0guard.pd.get(7, 1)returns 0, triggering integer divide-by-zero.Verification:
-fsanitize=address).layer load_param failedinstead of crashing.Fixes #6911