fix(net): add blob_index bounds check in load_param - #6916
Open
beilzx wants to merge 1 commit into
Open
Conversation
A malformed .param file with an under-reported blob_count can cause blob_index to grow beyond d->blobs.size(), leading to out-of-bounds read/write via Blob& blob = d->blobs[blob_index]. This patch adds bounds checks before both bottom-blob and top-blob indexing, returning -1 and cleaning up the partial net state when an out-of-range index is detected. Fixes Tencent#6913
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A malformed
.paramfile with an under-reportedblob_countcan causeblob_indexto grow beyondd->blobs.size(), leading to out-of-bounds read/write viaBlob& blob = d->blobs[blob_index].Changes
blob_index >= d->blobs.size()bounds check before bottom-blob assignmentblob_index >= d->blobs.size()bounds check before top-blob assignment-1and clean up partial net state on out-of-range detectionVerification
-fsanitize=address)net.cpp:1464)./ncnn_param poc6exits cleanly withEXIT=0, no ASAN errorsFixes #6913