Fix empty string bounds check in ParamDict::load_param - #6918
Open
beilzx wants to merge 1 commit into
Open
Conversation
Guard trailing-quote stripping with an emptiness check to prevent size_t underflow and heap-buffer-overflow when parsing malformed .param files. Fixes Tencent#6915
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a heap-buffer-overflow (READ) in
ParamDict::load_paramwhen parsing string parameters in.paramfiles.Changes
!d->params[id].s.empty() &&) before accessings[s.size() - 1]to strip trailing quotes.size_tunderflow when the parsed string is empty, which previously caused an out-of-bounds heap read.Verification
./ncnn_param poc5exits cleanly without ASAN errors.Fixes #6915