Skip to content

fix(slider): 修复受控模式下陷入死循环问题 #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anlyyao merged 2 commits into from
Jan 9, 2026
Merged

fix(slider): 修复受控模式下陷入死循环问题 #4170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8adfe09
fix(slider): 修复受控模式下陷入死循环问题
Boomkaa Jan 5, 2026
c975c0f
fix: 修复单测问题
Boomkaa Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/components/slider/slider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,11 @@ export default class Slider extends SuperComponent {
}

triggerValue(value?: SliderValue) {
if (this.preval === value) return;
this.preval = value;
const trimmedValue = trimValue(value, this.properties);
if (JSON.stringify(this.preval) === JSON.stringify(trimmedValue)) return;
this.preval = trimmedValue;
this._trigger('change', {
value: trimValue(value, this.properties),
value: trimmedValue,
});
}

Expand Down Expand Up @@ -215,7 +216,10 @@ export default class Slider extends SuperComponent {
const value = trimValue(newValue, this.properties);
const realLabel = this.getLabelByValue(value);

this.triggerValue(value);
// 避免受控模式下死循环，同时不影响初始化后的首次点击
if (this.preval !== undefined) {
this.preval = value;
}

const setValueAndTrigger = () => {
this.setData({
Expand Down
Loading