Skip to content

test(SwipeCell): improve test coverage #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

test(SwipeCell): improve test coverage #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/test-coverage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ module.exports = {
stepper: { statements: '100%', branches: '100%', functions: '100%', lines: '100%' },
steps: { statements: '100%', branches: '100%', functions: '100%', lines: '100%' },
sticky: { statements: '67.85%', branches: '30%', functions: '85.71%', lines: '69.09%' },
swipeCell: { statements: '4.42%', branches: '0%', functions: '0%', lines: '4.67%' },
swipeCell: { statements: '100%', branches: '100%', functions: '100%', lines: '100%' },
swiper: { statements: '3.77%', branches: '0.9%', functions: '1.4%', lines: '3.89%' },
switch: { statements: '100%', branches: '100%', functions: '100%', lines: '100%' },
tabBar: { statements: '10%', branches: '0%', functions: '0%', lines: '10.81%' },
Expand Down
41 changes: 26 additions & 15 deletions src/swipe-cell/SwipeCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,28 @@ export interface SwipeCellProps extends TdSwipeCellProps, StyledProps {}

const threshold = '50%';

export const syncOpenedState = (
rootRef: React.RefObject<HTMLDivElement>,
opened: SwipeCellProps['opened'],
getOpenedSide: (opened: SwipeCellProps['opened']) => SideType | undefined,
expand: (side: SideType) => void,
close: () => void,
) => {
if (!rootRef.current) return;

const side = getOpenedSide(opened);

if (side === 'left' || side === 'right') {
// 初始化 expanded，等待 dom 加载完，获取 left/right 宽度后无动画设置展开状态
// 防止 left/right 为列表时，获取真实宽度有误
setTimeout(() => {
expand(side);
}, 100);
} else {
close();
}
};

const SwipeCell = forwardRef<SwipeCellRef, SwipeCellProps>((originProps, ref) => {
const props = useDefaultProps<SwipeCellProps>(originProps, swipeCellDefaultProps);

Expand All @@ -49,10 +71,10 @@ const SwipeCell = forwardRef<SwipeCellRef, SwipeCellProps>((originProps, ref) =>
return;
}
if (isArray(opened)) {
if (open[1] && rightRef.current) {
if (opened[1] && rightRef.current) {
return 'right';
}
if (open[0] && leftRef.current) {
if (opened[0] && leftRef.current) {
return 'left';
}
}
Expand Down Expand Up @@ -130,7 +152,7 @@ const SwipeCell = forwardRef<SwipeCellRef, SwipeCellProps>((originProps, ref) =>
} else {
close();
}
window.setTimeout(() => {
setTimeout(() => {
ctx.dragging = false;
});
} else {
Expand All @@ -156,18 +178,7 @@ const SwipeCell = forwardRef<SwipeCellRef, SwipeCellProps>((originProps, ref) =>
}));

useLayoutEffect(() => {
if (!rootRef.current) return;
const side = getOpenedSide(opened);

if (['left', 'right'].includes(side)) {
// 初始化 expanded，等待 dom 加载完，获取 left/right 宽度后无动画设置展开状态
// 防止 left/right 为列表时，获取真实宽度有误
setTimeout(() => {
expand(side as SideType);
}, 100);
} else {
close();
}
syncOpenedState(rootRef, opened, getOpenedSide, expand, close);
// 可以保证expand，close正常执行
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [opened, rootRef.current]);
Expand Down
Loading
Loading