Skip to content

perf(Tree): optimize tree traversal and node updates to prevent stack overflow #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
+4 −4
Open

perf(Tree): optimize tree traversal and node updates to prevent stack overflow #3903

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a0527b
perf(Tree): optimize tree traversal and node updates to prevent stack…
RylanBot Oct 21, 2025
c19043e
perf(Tree): wrap components in memo
RylanBot Oct 21, 2025
8015e08
chore: update common
RylanBot Oct 21, 2025
68d063b
chore: update common
github-actions[bot] Oct 23, 2025
caeac16
chore: merge develop
github-actions[bot] Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/common
Open in desktop
Submodule common updated 5 files
+0 −0 docs/web/design/image-viewer.md
+1 −1 docs/web/design/input-number.md
+32 −16 js/tree-v1/tree-node.ts
+24 −15 js/tree-v1/tree-store.ts
+1 −1 style/web/components/menu/_index.less
2 changes: 1 addition & 1 deletion packages/components/tree/Tree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,4 +401,4 @@ const Tree = forwardRef<TreeInstanceFunctions<TreeOptionData>, TreeProps>((origi

Tree.displayName = 'Tree';

export default Tree;
export default React.memo(Tree);
4 changes: 2 additions & 2 deletions packages/components/tree/TreeItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ const TreeItem = forwardRef(
throw new Error('invalid type of icon');
}

if (!node.isLeaf()) {
if (!node.vmIsLeaf) {
isDefaultIcon = true;
if (node.loading && node.expanded) {
return <Loading loading={true} />;
Expand Down Expand Up @@ -403,4 +403,4 @@ const TreeItem = forwardRef(

TreeItem.displayName = 'TreeItem';

export default TreeItem;
export default React.memo(TreeItem);
Loading