fix(Popup): triggerElement string not working as CSS selector
#3940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RylanBot
requested review from
HaixingOoO,
NWYLZW,
ZWkang,
carolin913,
honkinglin and
uyarn
as code owners
|
|
RylanBot
changed the title
triggerElement string not working as CSS selector
commit: |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the popup trigger mechanism by replacing inline event handler props with direct DOM event listeners, fixes a typo in the TooltipLite component's displayName, and updates snapshot tests accordingly.
- Migrated trigger event handling from React props to native DOM event listeners in
useTrigger.tsx - Fixed displayName from 'Tooltiplite' to 'TooltipLite' for consistency
- Enhanced event listener utilities to support options like
passive
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/snap/snapshots/csr.test.jsx.snap | Updated snapshot to reflect reordered CSS classes in button element |
| packages/components/tooltip/TooltipLite.tsx | Fixed displayName capitalization from 'Tooltiplite' to 'TooltipLite' |
| packages/components/popup/hooks/useTrigger.tsx | Refactored trigger event handling from React synthetic events to native DOM listeners |
| packages/components/popup/PopupPlugin.tsx | Added dynamic componentName using classPrefix from config |
| packages/components/popup/Popup.tsx | Updated to use refactored useTrigger hook API |
| packages/components/_util/ref.ts | Added mergeRefs utility function for combining multiple refs |
| packages/components/_util/listener.ts | Added options parameter support for addEventListener/removeEventListener |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RylanBot
force-pushed
the
rylan/refactor/popup
branch
from
557a202 to
8fc31af
Compare
RylanBot
force-pushed
the
rylan/refactor/popup
branch
from
c19761d to
029f191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
ref和props的穿透useInnerPopupVisible解决📝 更新日志
fix(Popup): 修复
triggerElement类型为字符串时未正确作为元素选择器解析的问题fix(Popup): 修复
children/triggerElement为不支持ref穿透的封装组件时，弹窗无法正常出现的问题fix(Popup): 修复自定义的全局
classPrefix未生效的问题本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单