Skip to content

fix(FormItem): update readOnly prop handling for supported components #3955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(FormItem): update readOnly prop handling for supported components #3955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/components/form/FormItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ export interface FormItemInstance {
resetValidate?: () => void;
}

const READONLY_SUPPORTED_COMP = ['Input', 'Textarea', 'InputNumber', 'TagInput', 'RadioGroup', 'Select', 'ColorPicker'];

const FormItem = forwardRef<FormItemInstance, FormItemProps>((originalProps, ref) => {
const [locale, t] = useLocaleReceiver('form');
const { classPrefix, form: globalFormConfig } = useConfig();
Expand Down Expand Up @@ -524,9 +526,13 @@ const FormItem = forwardRef<FormItemInstance, FormItemProps>((originalProps, ref
ctrlKey = ctrlKeyMap.get(child.type) || 'value';
}
const childProps = child.props as any;
return React.cloneElement(child, {

// @ts-ignore
const readOnlyKey = READONLY_SUPPORTED_COMP.includes(child?.type?.displayName) ? 'readonly' : 'readOnly';

const cloneProps = {
disabled: disabledFromContext,
readOnly: readonlyFromContext,
[readOnlyKey]: readonlyFromContext,
...childProps,
[ctrlKey]: formValue,
onChange: (value: any, ...args: any[]) => {
Expand All @@ -538,7 +544,8 @@ const FormItem = forwardRef<FormItemInstance, FormItemProps>((originalProps, ref
handleItemBlur();
childProps?.onBlur?.call?.(null, value, ...args);
},
});
};
return React.cloneElement(child, cloneProps);
}
return child;
})}
Expand Down
Loading