Skip to content

fix(SelectInput): onTagChange not work when tagInputProps.tagProps.onClose #4070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uyarn merged 5 commits into from
Jan 16, 2026
+19 −6
Merged

fix(SelectInput): onTagChange not work when tagInputProps.tagProps.onClose #4070

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9734901
fix(SelectInput): `tagInputProps.tagProps` not work
RylanBot Jan 8, 2026
b1d2726
chore: stash changelog [ci skip]
tdesign-bot Jan 8, 2026
990d763
fix(Select): `props.tagInputProps?.tagProps` not work
RylanBot Jan 9, 2026
875ad92
fix(Tag): `closeable` not work
RylanBot Jan 9, 2026
e690e0f
chore: update changelog
RylanBot Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/select-input/useMultiple.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,12 @@ export default function useMultiple(props: SelectInputProps) {
if (context?.trigger === 'enter' || context?.trigger === 'blur') return;
setTInputValue(val, { trigger: context.trigger, e: context.e });
}}
tagProps={props.tagProps}
onClear={p.onInnerClear}
// [Important Info]: SelectInput.blur is not equal to TagInput, example: click popup panel
onFocus={handleFocus}
onBlur={handleBlur}
{...props.tagInputProps}
tagProps={{ ...props.tagProps, ...props.tagInputProps?.tagProps }}
inputProps={{
...props.inputProps,
readOnly: !props.allowInput || readOnly,
Expand Down
6 changes: 5 additions & 1 deletion packages/components/tag-input/useTagList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,19 @@ export default function useTagList(props: TagInputProps) {
? [<Fragment key="display-node">{displayNode}</Fragment>]
: newList?.map((item, index) => {
const tagContent = isFunction(tag) ? tag({ value: item }) : tag;
const handleClose = (context) => {
tagProps?.onClose?.(context);
onClose({ e: context?.e, index });
};
return (
<Tag
key={index}
size={size}
disabled={disabled}
onClose={(context) => onClose({ e: context.e, index })}
closable={!readOnly && !disabled}
{...getDragProps?.(index, item)}
{...tagProps}
onClose={handleClose}
>
{tagContent ?? item}
</Tag>
Expand Down
Loading