fix(anchor): active link set before scroll recalculation on click#6511
Closed
Copilot wants to merge 1 commit intowesley/fix/anchor-linkfrom
Closed
fix(anchor): active link set before scroll recalculation on click#6511Copilot wants to merge 1 commit intowesley/fix/anchor-linkfrom
Copilot wants to merge 1 commit intowesley/fix/anchor-linkfrom
Conversation
16 tasks
Copilot
AI
changed the title
[WIP] [3272] Fix link for anchor
fix(anchor): active link set before scroll recalculation on click
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking an anchor link (e.g.
content-4) would snap back to a previously calculated anchor (e.g.content-3) when the scroll container height isn't an exact multiple of the content height.Root cause:
setCurrentActiveLink(link)was called after theif (!anchor) returnguard inhandleScrollTo, so the scroll listener could fire and overwrite the user's selection before it was ever recorded.Fix:
setCurrentActiveLink(link)to execute before the early-return guard, ensuring the user's click is committed immediately and cannot be overridden by a concurrent scroll recalculation.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.