-
Notifications
You must be signed in to change notification settings - Fork 382
feat(attach): support global attach config #3437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d35d7f0
feat: support global config attach
liweijie0812 cb8b22d
chore: update common
liweijie0812 00fb3e3
chore: api update
liweijie0812 7863be2
fix: test
liweijie0812 4286dc0
fix: test
liweijie0812 64f4192
chore: update snapshot
github-actions[bot] b44ffd3
chore: clear typograph code
liweijie0812 55b112c
chore: clear typograph code
liweijie0812 5b337f5
chore: merge develop
github-actions[bot] 0452440
Merge branch 'feat/global/attach' of https://github.com/Tencent/tdesi…
liweijie0812 44dda19
chore: revert irrelevant docs change
uyarn ed28dd7
feat: fix config
uyarn aae7674
feat: fix config
uyarn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule _common
updated
2 files
| +1 −0 | js/global-config/default-config.ts | |
| +4 −1 | js/utils/getPosition.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { computed } from '@vue/composition-api'; | ||
| import { useConfig } from './useConfig'; | ||
| import { AttachNode } from '../common'; | ||
|
|
||
| const defaultAttach = 'body'; | ||
|
|
||
| /** | ||
| * useAttach | ||
| * | ||
| * 挂载节点 优先级: | ||
| * | ||
| * props attach -> globalConfig.attach.component -> globalConfig.attach -> default = 'body' | ||
| */ | ||
|
|
||
| export function useAttach(name: string, attach: AttachNode) { | ||
| const { globalConfig } = useConfig(); | ||
| const attachVal = computed<AttachNode>( | ||
| () => attach || globalConfig.value.attach?.[name] || globalConfig.value?.attach || defaultAttach, | ||
| ); | ||
| return attachVal; | ||
| } | ||
|
|
||
| export default useAttach; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.