fix(menu): fix menu item auto-flip failure #3744
Open
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSS1102
requested review from
LoopZhou,
chaishi,
liweijie0812,
maoyiluo,
uyarn and
xiaosansiji
as code owners
|
|
|
tdesign-vue2-demo-compiler-2-6 commit: |
RSS1102
changed the title
RSS1102
force-pushed
the
rss1102/fix/menu-item/auto-flip
branch
from
b0b33b9 to
3738031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
原因:
Popper 在
expandAnimation动画开始前创建可能尺寸为 0flip modifier 检测时认为"不会溢出"（因为尺寸是 0）
选择了初始的
placement: right-start后续即使动画完成后元素有了正确尺寸
update()只调整位置，不会重新选择placement所以始终停留在
right-start，不会翻转到top解决方法
使用
forceUpdate强制重新运行所有modifiers的完整生命周期可能会影响
Select、SelectInput、Dropdown，Popconfirm、StickyItem、Tooltip、Guide等使用Popup组件📝 更新日志
fix(menu): 修复菜单项自动翻转失效
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单