-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: 审计日志增加scen,scen_code,scen_desc字段,支撑上层应用使用 --story=129221126 #8595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuyudeqiu
wants to merge
2
commits into
TencentBlueKing:v3.14.x
Choose a base branch
from
yuyudeqiu:dev_auditlog
base: v3.14.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
src/scene_server/admin_server/upgrader/y3.14.202601121450/add_audit_scene_index.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* | ||
| * Tencent is pleased to support the open source community by making | ||
| * 蓝鲸智云 - 配置平台 (BlueKing - Configuration System) available. | ||
| * Copyright (C) 2017 Tencent. All rights reserved. | ||
| * Licensed under the MIT License (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at http://opensource.org/licenses/MIT | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on | ||
| * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, | ||
| * either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| * We undertake not to change the open source license (MIT license) applicable | ||
| * to the current version of the project delivered to anyone in the future. | ||
| */ | ||
|
|
||
| package y3_14_202601121450 | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "configcenter/src/common" | ||
| "configcenter/src/common/blog" | ||
| "configcenter/src/scene_server/admin_server/upgrader" | ||
| "configcenter/src/storage/dal" | ||
| "configcenter/src/storage/dal/types" | ||
|
|
||
| "go.mongodb.org/mongo-driver/bson" | ||
| ) | ||
|
|
||
| func addAuditLogSceneIndex(ctx context.Context, db dal.RDB, conf *upgrader.Config) error { | ||
| idxArr, err := db.Table(common.BKTableNameAuditLog).Indexes(ctx) | ||
| if err != nil { | ||
| blog.Errorf("get table %s index error. err:%s", common.BKTableNameAuditLog, err.Error()) | ||
| return err | ||
| } | ||
|
|
||
| createIdxArr := []types.Index{ | ||
| {Name: "index_scene", Keys: bson.D{{common.BKSceneField, 1}}, Background: true}, | ||
| {Name: "index_scene_code", Keys: bson.D{{common.BKSceneCodeField, 1}}, Background: true}, | ||
| } | ||
| for _, idx := range createIdxArr { | ||
| exist := false | ||
| for _, existIdx := range idxArr { | ||
| if existIdx.Name == idx.Name { | ||
| exist = true | ||
| break | ||
| } | ||
| } | ||
| if exist { | ||
| continue | ||
| } | ||
| if err := db.Table(common.BKTableNameAuditLog).CreateIndex(ctx, idx); err != nil && !db.IsDuplicatedError(err) { | ||
| blog.ErrorJSON("create index to BKTableNameAuditLog error, err:%s, current index:%s, all create index:%s", err.Error(), idx, createIdxArr) | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } |
42 changes: 42 additions & 0 deletions
42
src/scene_server/admin_server/upgrader/y3.14.202601121450/pkg.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /* | ||
| * Tencent is pleased to support the open source community by making | ||
| * 蓝鲸智云 - 配置平台 (BlueKing - Configuration System) available. | ||
| * Copyright (C) 2017 Tencent. All rights reserved. | ||
| * Licensed under the MIT License (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at http://opensource.org/licenses/MIT | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on | ||
| * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, | ||
| * either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| * We undertake not to change the open source license (MIT license) applicable | ||
| * to the current version of the project delivered to anyone in the future. | ||
| */ | ||
|
|
||
| package y3_14_202601121450 | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "configcenter/src/common/blog" | ||
| "configcenter/src/scene_server/admin_server/upgrader" | ||
| "configcenter/src/storage/dal" | ||
| ) | ||
|
|
||
| func init() { | ||
| upgrader.RegistUpgrader("y3.14.202601121450", upgrade) | ||
| } | ||
|
|
||
| func upgrade(ctx context.Context, db dal.RDB, conf *upgrader.Config) (err error) { | ||
|
|
||
| blog.Infof("start execute y3.14.202601121450") | ||
| err = addAuditLogSceneIndex(ctx, db, conf) | ||
| if err != nil { | ||
| blog.Errorf("upgrade y3.14.202601121450 add audit log scene index failed, error: %v", err) | ||
| return err | ||
| } | ||
| blog.Infof("execute y3.14.202601121450, add audit log scene index success!") | ||
|
|
||
| return nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不要放在header里去实现
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
原本定的方案是放到header里面,是否放到body中更合适?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
之前的技术实现方案没有对过,这个场景不适合放在header里
可以修改一下技术方案,评审通过后再编码提交~