Toolfixes #1544
Draft
Toolfixes #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redeix
previously approved these changes
Aug 6, 2025
Pyritie
previously approved these changes
Aug 6, 2025
|
Btw have you tested the knives in game? I feel like they would break insanely fast when collecting straw |
|
i have, and they do, which is intended TFC behavior |
Signed-off-by: Pyritie <[email protected]>
|
xikaro my new account is gustovafing2 |
sounds like something a spy would say |
|
@Zippity what still needs to be done here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the new behavior?
GTCEU tools that can harvest grass for straw now take damage on harvest.
Implementation Details
Custom event handler on break of blocks tagged with
tfc:mineable_with_sharp_tool. If the tool breaking the grass is taggedtfc:sharp_tools(TFC's tag for grass-harvesting items) then the item takes one point of damage. AoE tools work as intended and take multiple points of damage, while single block tools only take one.Outcome
Fixes #965
Potential Compatibility Issues
None, as long as
tfc:sharp_toolsis assigned to the right tools.