-
Notifications
You must be signed in to change notification settings - Fork 139
ochem for fission #2218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
ochem for fission #2218
Conversation
| .flags(GTMaterialFlags.DISABLE_DECOMPOSITION) | ||
| .iconSet(GTMaterialIconSet.FLINT) | ||
| .components('10x ammonia', '1x tfg:tungstate', '4x water') | ||
| .components('10x ammonium', '1x tfg:tungstate', '4x water') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this all still properly loop in the tungsten line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the tungsten line recipes are hardcoded, yeah this doesn't affect them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change though? Because the formula gonna get wrong ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah the formula was showing NH3 when it should be +NH4, unless I am mistaken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn’t Ammonia NH3 and Ammonium NH4 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcoded? tom changed them all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats what I meant, the recipe gives ammonia, its not generated from the components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but are the formulas still balance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they should be
|
|
||
| // #region ochem that tom wants for something? | ||
|
|
||
| event.create('tfg:glucose') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to give these a bunch of different icon sets so they don't look so similar
Redeix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix recipe ids
need core to work for other stuff
Signed-off-by: Pyritie <[email protected]>
|
This still needs some more time to cook |
|
ok I've turned it back into a draft |
also the start of some the chitin stuff I want to do
don't push this until we get everything sorted/I finish it