Merge pull request #1285 from chrisdennis/connection-closed-typo

Myron Scott · web-flow · commit 2b1d369feb39 · 2022-09-09T13:08:26.000-07:00
Fix condition nesting to prevent erroneous ConnectionClosedException throws
diff --git a/tc-client/src/main/java/com/tc/object/ClientEntityManagerImpl.java b/tc-client/src/main/java/com/tc/object/ClientEntityManagerImpl.java
@@ -498,9 +498,9 @@ private Invocation.Task queueInFlightMessage(EntityID eid, Supplier<NetworkVoltr
           if (!channel.getProductID().isReconnectEnabled()) {
             throwClosedExceptionOnMessage(inFlight, "connection not capable of resend");
           }
-        } else {
-          throwClosedExceptionOnMessage(inFlight, "Connection closed before sending message");
         }
+      } else {
+        throwClosedExceptionOnMessage(inFlight, "Connection closed before sending message");
       }
       return () -> {
         if (inFlight.cancel()) {

Original file line number	Diff line number	Diff line change
`@@ -498,9 +498,9 @@ private Invocation.Task queueInFlightMessage(EntityID eid, Supplier<NetworkVoltr`
`498`	`498`	`if (!channel.getProductID().isReconnectEnabled()) {`
`499`	`499`	`throwClosedExceptionOnMessage(inFlight, "connection not capable of resend");`
`500`	`500`	`}`
`501`		`- } else {`
`502`		`- throwClosedExceptionOnMessage(inFlight, "Connection closed before sending message");`
`503`	`501`	`}`
	`502`	`+ } else {`
	`503`	`+ throwClosedExceptionOnMessage(inFlight, "Connection closed before sending message");`
`504`	`504`	`}`
`505`	`505`	`return () -> {`
`506`	`506`	`if (inFlight.cancel()) {`