TDB-19271 : implementing a common security logger #1374
Conversation
| consoleAppender.start(); | ||
|
|
||
| ch.qos.logback.classic.Logger SECURITY_LOGGER = loggerContext.getLogger("SECURITY_LOGGER"); | ||
| SECURITY_LOGGER.setLevel(Level.DEBUG); |
There was a problem hiding this comment.
you can probably use normal variable conventions here.
| root.addAppender(continuingAppender); | ||
| disableBufferingAppender(continuingAppender); | ||
| installSecurityLogger(logDirFile); |
There was a problem hiding this comment.
should calling this method be conditional on having these logs here?
There was a problem hiding this comment.
Yes, calling this method will be conditional.
serverLogPath will be the default option if user is not passing security log path in propFile
|
|
||
| private void logWithMDC(String message, Consumer<String> consumer) { | ||
| try { | ||
| MDC.put("SECURITY_LOGGER_NAME", name); |
There was a problem hiding this comment.
This looks like an unconventional usage of MDC. Normally this would be some context information that changes with each log like username or IP for the particular connection or some other identifying information that changes at runtime. Coding the name of the logger that is available at compile time this way seems like overkill. Is there a more conventional way to get the logger name in the log?
There was a problem hiding this comment.
Refactred this MDC based substitution in log with String concatenationof name with logging message.
No description provided.