Skip to content

Conversation

nishchay-naresh-IBM
Copy link

In adding my name to the list of publishers, I agree to the current contributor agreement
as referred to here: https://github.com/terracotta-oss/contributing/blob/main/CONTRIBUTING.md.
I also agree to follow all of the responsibilities and policies pertaining to being a project
"Publisher", as listed in the same document.

@mathieucarbou-ibm
Copy link
Contributor

@nishchay-naresh-IBM : the changes as-is are all OK, but I do not see any test making sure this is backward compatible.
There are such tests in the project if I remember (BackwardCompatibilityTest ?).

You can build a kit from master, then spawn a node and activate it, then kill it, swap the kit from the one built from your branch, and restart it with the config folder created previously. Like if you did a rolling restart to upgrade the kit.

Server should start and then you should be able to trigger a config-tool set command to set the security log dir.

Let me know when you did this test. You can also save the files and put it in the project for BackwardCompatibilityTest

Copy link
Contributor

@mathieucarbou-ibm mathieucarbou-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Ensure a BackwardCompatibilityTest is done

@mathieucarbou-ibm mathieucarbou-ibm marked this pull request as draft August 25, 2025 13:24
@mathieucarbou-ibm
Copy link
Contributor

@nishchay-naresh-IBM : moving the master PR to draft for now.
Let's focus on the release/5.10 PR first: #1215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants