Sync rails from Heroku production snapshot#1012
Open
luandro wants to merge 24 commits intoTerrastories:masterfrom
Open
Sync rails from Heroku production snapshot#1012luandro wants to merge 24 commits intoTerrastories:masterfrom
luandro wants to merge 24 commits intoTerrastories:masterfrom
Conversation
Rootless Docker cannot bind host port 80 when we run Attaching to db-1, web-1, so the Heroku snapshot fails to start. Adding a local remaps the service to ports 3000/3035, matching the prior origin/master setup without requiring sysctl changes or sudo.
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Rudo Kemper <31662219+rudokemper@users.noreply.github.com>
Co-authored-by: Rudo Kemper <31662219+rudokemper@users.noreply.github.com>
Co-authored-by: Rudo Kemper <31662219+rudokemper@users.noreply.github.com>
Expose map credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs our repository with the exact Rails/React snapshot currently deployed on Heroku
(
terrastoriesapp).Heroku
production/maincontains a one-time export commit (576f922) that froze Ruby 3.2.4, Rails7.1.3, Shakapacker 7.x, and the React 18-era dependencies. This PR commits that slug snapshot onto
origin/masterso we can review and merge the deployed runtime back into version control.What changed
.subdir,rails/Aptfile, and other Heroku slug scaffolding files from the deployedslug.
rails/.ruby-versionto3.2.4, Gemfile/Ruby dependencies to the deployed set, andsynced
rails/Gemfile.lock.package.json,yarn.lock, and React/webpack configuration fromHeroku (React 18, Shakapacker 7).
repo source with production.
Why
masterstill reflects the old 3.0.x / Rails 7.0 stack, while production has alreadymoved ahead.
scripts, upgrade PRs).
masterwill match what’s live, enabling future upgrades from a consistent baseline.