Conversation
So that we can capture scenes showing shadows at a particular time of the day in stories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
In v7 it used to be possible to share the default timeline state. Re-implement it in v8 so that we can capture scenes showing shadows at a particular time of the day in stories.
Note that the default timeline state is captured in the init source as a model with ID
defaultTimelineinstead of introducing a hardcoded config key for timeline settings.Test me
Run through this story, observe that it captures different times of the day and the timeline playback state.
Checklist
doc/.