Don't overwrite existing CMAKE_EXE_LINKER_FLAGS#1262
Merged
flibitijibibo merged 1 commit intoTerryCavanagh:masterfrom Jan 24, 2026
Merged
Don't overwrite existing CMAKE_EXE_LINKER_FLAGS#1262flibitijibibo merged 1 commit intoTerryCavanagh:masterfrom
flibitijibibo merged 1 commit intoTerryCavanagh:masterfrom
Conversation
Collaborator
|
2.4 backport 30bdb47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
The CMake logic was previously overriding any existing CMAKE_EXE_LINKER_FLAGS, which is liable to break cross-compilation.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement