You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes#1204 by replacing the two submenu items "Show namespace" and "Hide namespace" with one single submenu item.
In addition this submenu is only available, if the NUnit display format is checked. If another display format is checked, the submenu is not available.
If a display format is selected, the menu is not closed automatically anymore. Instead it's kept open, so that the user can select the appropriate submenu item right away.
From technical point of view:
we can use the ToolStripMenuItem event Closing to suppress that the menu is automatically closed when an item is clicked. The event parameter provides some information about the closing reason to act accordingly.
This applies for the entire 'Display format' menu item now and not only the 'NUnit' menu item. But as we plan to adapt the 'Fixture list' and 'Test list' menu item too, that's also fine.
BTW: although the menu is not closed automatically, the tree view is updated to the newly selected display format right away.
I decided to keep the entire logic for adding/removing the submenu in the View class. From my point of view that's a pure UI part, so involving the Presenter class for this step seems to be an overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1204 by replacing the two submenu items "Show namespace" and "Hide namespace" with one single submenu item.
In addition this submenu is only available, if the NUnit display format is checked. If another display format is checked, the submenu is not available.
If a display format is selected, the menu is not closed automatically anymore. Instead it's kept open, so that the user can select the appropriate submenu item right away.