Skip to content
This repository was archived by the owner on Dec 10, 2025. It is now read-only.

Don't throw when extension Path is not found #73

Merged
CharliePoole merged 1 commit into from
Sep 27, 2025
Merged

Don't throw when extension Path is not found #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 19 additions & 21 deletions src/testcentric.extensibility/ExtensionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,20 +488,22 @@ internal void FindExtensionsInAssembly(ExtensionAssembly extensionAssembly)

ExtensionNode extensionNode = BuildExtensionNode(extensionAttr, extensionType, extensionAssembly);
ExtensionPoint? extensionPoint = BuildExtensionPoint(extensionNode, extensionType, extensionAssembly.FromWildCard);
if (extensionPoint is null)
log.Warning($"Extension ignored - Unable to deduce ExtensionPoint.");

// TODO: Ignoring version requirement for now. Decide whether or how to implement
// it for varying hosts. Replace with ExtensibilityVersion?
//string? versionArg = extensionAttr.GetNamedArgument("EngineVersion") as string;
//if (versionArg is not null && !CheckRequiredVersion(versionArg, extensionPoint))
// log.Warning($" Ignoring {extensionType.Name}. It requires version {versionArg}.");
//else
//{
AddExtensionPropertiesToNode(extensionType, extensionNode);

_extensions.Add(extensionNode);
extensionPoint.Install(extensionNode);
log.Info($" Installed at path {extensionNode.Path}");
//}
else
{
AddExtensionPropertiesToNode(extensionType, extensionNode);

_extensions.Add(extensionNode);
extensionPoint.Install(extensionNode);
log.Info($" Installed at path {extensionNode.Path}");
}
}
}
}
Expand All @@ -519,24 +521,20 @@ private ExtensionNode BuildExtensionNode(CustomAttribute attr, TypeDefinition ty
return node;
}

private ExtensionPoint BuildExtensionPoint(ExtensionNode node, TypeDefinition type, bool fromWildCard)
private ExtensionPoint? BuildExtensionPoint(ExtensionNode node, TypeDefinition type, bool fromWildCard)
{
ExtensionPoint? ep;

if (node.Path is null)
{
ep = DeduceExtensionPointFromType(type);
if (ep is null)
throw new ExtensibilityException($"Unable to deduce ExtensionPoint for Type {type.FullName}. Specify Path on ExtensionAttribute to resolve.");

log.Debug($" Deduced Path {ep.Path}");
node.Path = ep.Path;
}
if (node.Path is not null)
ep = GetExtensionPoint(node.Path);
else
{
ep = GetExtensionPoint(node.Path);
if (ep is null)
throw new ExtensibilityException($"Unable to locate ExtensionPoint for Type {type.FullName}. The Path {node.Path} cannot be found.");
ep = DeduceExtensionPointFromType(type);
if (ep is not null)
{
log.Debug($" Deduced Path {ep.Path}");
node.Path = ep.Path;
}
}

return ep;
Expand Down
Loading