added ApproveResultsProcessor + some renames

Author: kkozmic

TestStack.ConventionTests/Convention.cs

@@ -32,7 +32,7 @@ static Convention()
         public static void Is<TDataSource>(IConvention<TDataSource> convention, TDataSource data)
             where TDataSource : IConventionData
         {
-            Is(convention, data, new ConventionResultExceptionReporter());
+            Is(convention, data, new ThrowOnFailureResultsProcessor());
         }
 
         public static void Is<TDataSource>(IConvention<TDataSource> convention, TDataSource data, IResultsProcessor reporter) 

TestStack.ConventionTests/Reporting/ApproveResultsProcessor.cs

@@ -0,0 +1,24 @@
+namespace TestStack.ConventionTests.Reporting
+{
+    using ApprovalTests;
+    using ApprovalTests.Core.Exceptions;
+    using TestStack.ConventionTests.Internal;
+
+    public class ApproveResultsProcessor : IResultsProcessor
+    {
+        public void Process(params ConventionResult[] results)
+        {
+            try
+            {
+                var conventionReportTextRenderer = new ConventionReportTextRenderer();
+                conventionReportTextRenderer.Process(results);
+                Approvals.Verify(conventionReportTextRenderer.Output);
+            }
+            catch (ApprovalException ex)
+            {
+                throw new ConventionFailedException("Approved exceptions for convention differs\r\n\r\n" + ex.Message,
+                    ex);
+            }
+        }
+    }
+}

TestStack.ConventionTests/Reporting/ConventionReportTextRenderer.cs

@@ -5,11 +5,11 @@
 
     public class ConventionReportTextRenderer : IResultsProcessor
     {
-        public void Process(params ConventionResult[] conventionResult)
+        public void Process(params ConventionResult[] results)
         {
             var stringBuilder = new StringBuilder();
 
-            foreach (var conventionReport in conventionResult)
+            foreach (var conventionReport in results)
             {
                 var title = string.Format("{0}: '{1}' for '{2}'", conventionReport.Result, conventionReport.ConventionTitle,
                     conventionReport.DataDescription);

TestStack.ConventionTests/Reporting/ConventionReportTraceRenderer.cs

@@ -5,10 +5,10 @@
 
     public class ConventionReportTraceRenderer : IResultsProcessor
     {
-        public void Process(params ConventionResult[] conventionResult)
+        public void Process(params ConventionResult[] results)
         {
             var conventionReportTextRenderer = new ConventionReportTextRenderer();
-            conventionReportTextRenderer.Process(conventionResult);
+            conventionReportTextRenderer.Process(results);
             Trace.WriteLine(conventionReportTextRenderer.Output);
         }
     }

TestStack.ConventionTests/Reporting/HtmlReportRenderer.cs

@@ -14,7 +14,7 @@ public HtmlReportRenderer(string assemblyDirectory)
             file = Path.Combine(assemblyDirectory, "Conventions.htm");
         }
 
-        public void Process(params ConventionResult[] conventionResult)
+        public void Process(params ConventionResult[] results)
         {
             var sb = new StringBuilder();
             var html = new HtmlTextWriter(new StringWriter(sb));
@@ -29,7 +29,7 @@ public void Process(params ConventionResult[] conventionResult)
             html.Write("Project Conventions");
             html.RenderEndTag();
 
-            foreach (var conventionReport in conventionResult)
+            foreach (var conventionReport in results)
             {
                 html.RenderBeginTag(HtmlTextWriterTag.P);
                 html.RenderBeginTag(HtmlTextWriterTag.Div);

TestStack.ConventionTests/Reporting/IResultsProcessor.cs

@@ -4,6 +4,6 @@
 
     public interface IResultsProcessor
     {
-        void Process(params ConventionResult[] conventionResult);
+        void Process(params ConventionResult[] results);
     }
 }

TestStack.ConventionTests/Reporting/ConventionResultExceptionReporter.cs renamed to TestStack.ConventionTests/Reporting/ThrowOnFailureResultsProcessor.cs

@@ -3,13 +3,13 @@
     using System.Linq;
     using TestStack.ConventionTests.Internal;
 
-    public class ConventionResultExceptionReporter : IResultsProcessor
+    public class ThrowOnFailureResultsProcessor : IResultsProcessor
     {
-        public void Process(params ConventionResult[] conventionResult)
+        public void Process(params ConventionResult[] results)
         {
             var conventionReportTextRenderer = new ConventionReportTextRenderer();
-            conventionReportTextRenderer.Process(conventionResult);
-            if (conventionResult.Any(r => r.Result == TestResult.Failed))
+            conventionReportTextRenderer.Process(results);
+            if (results.Any(r => r.Result == TestResult.Failed))
             {
                 throw new ConventionFailedException(conventionReportTextRenderer.Output);
             }

TestStack.ConventionTests/TestStack.ConventionTests.csproj

@@ -64,12 +64,13 @@
     <Compile Include="Internal\ConventionContext.cs" />
     <Compile Include="Internal\ConventionResult.cs" />
     <Compile Include="Internal\NoDataFormatterFoundException.cs" />
+    <Compile Include="Reporting\ApproveResultsProcessor.cs" />
     <Compile Include="Reporting\CsvReporter.cs" />
     <Compile Include="Reporting\DefaultFormatter.cs" />
     <Compile Include="Reporting\HtmlReportRenderer.cs" />
     <Compile Include="Reporting\ConventionReportTextRenderer.cs" />
     <Compile Include="Reporting\ConventionReportTraceRenderer.cs" />
-    <Compile Include="Reporting\ConventionResultExceptionReporter.cs" />
+    <Compile Include="Reporting\ThrowOnFailureResultsProcessor.cs" />
     <Compile Include="Conventions\ClassTypeHasSpecificNamespace.cs" />
     <Compile Include="Conventions\ConventionSourceInvalidException.cs" />
     <Compile Include="ConventionData\ProjectFile.cs" />