Added tests to ensure the correct behaviour for the factories with respect to using builder values

Changed the AllPropertiesFactory to call the constructor using builder values rather than using AutoFixture

Author: robdmoore

TestStack.Dossier.Tests/Factories/AllPropertiesFactoryTests.cs

@@ -19,5 +19,23 @@ public void GivenAllPropertiesFactory_WhenBuilding_ThenAllPropertiesSet()
             dto.NotSetByCtorWithPrivateSetter.ShouldNotBe(null);
             dto.NotSetByCtorWithPublicSetter.ShouldNotBe(null);
         }
+
+        [Fact]
+        public void GivenAllPropertiesFactoryAgainstBuilderWithModifications_WhenBuilding_ThenCustomisationsAreUsed()
+        {
+            MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>
+                .CreateNew(new AllPropertiesFactory())
+                .Set(x => x.SetByCtorNoPropertySetter, "0")
+                .Set(x => x.SetByCtorWithPrivateSetter, "1")
+                .Set(x => x.SetByCtorWithPublicSetter, "2")
+                .Set(x => x.NotSetByCtorWithPrivateSetter, "3")
+                .Set(x => x.NotSetByCtorWithPublicSetter, "4");
+
+            dto.SetByCtorNoPropertySetter.ShouldBe("0");
+            dto.SetByCtorWithPrivateSetter.ShouldBe("1");
+            dto.SetByCtorWithPublicSetter.ShouldBe("2");
+            dto.NotSetByCtorWithPrivateSetter.ShouldBe("3");
+            dto.NotSetByCtorWithPublicSetter.ShouldBe("4");
+        }
     }
 }

TestStack.Dossier.Tests/Factories/AutoFixtureFactoryTests.cs

@@ -1,5 +1,4 @@
-using System;
-using Shouldly;
+using Shouldly;
 using TestStack.Dossier.Factories;
 using TestStack.Dossier.Tests.TestHelpers.Objects.Examples;
 using Xunit;

TestStack.Dossier.Tests/Factories/CallConstructorFactoryTests.cs

@@ -1,5 +1,4 @@
-using System;
-using Shouldly;
+using Shouldly;
 using TestStack.Dossier.Factories;
 using TestStack.Dossier.Tests.TestHelpers.Objects.Examples;
 using Xunit;
@@ -9,7 +8,7 @@ namespace TestStack.Dossier.Tests.Factories
     public class CallConstructorFactoryTests
     {
         [Fact]
-        public void GivenConstructorFactory_WhenBuilding_ThenOnlyConstructorPropertiesSet()
+        public void GivenCallConstructorFactory_WhenBuilding_ThenOnlyConstructorPropertiesSet()
         {
             MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>.CreateNew(new CallConstructorFactory());
 
@@ -19,5 +18,23 @@ public void GivenConstructorFactory_WhenBuilding_ThenOnlyConstructorPropertiesSe
             dto.NotSetByCtorWithPrivateSetter.ShouldBe(null);
             dto.NotSetByCtorWithPublicSetter.ShouldBe(null);
         }
+
+        [Fact]
+        public void GivenCallConstructorFactoryAgainstBuilderWithModifications_WhenBuilding_ThenCustomisationsAreUsed()
+        {
+            MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>
+                .CreateNew(new CallConstructorFactory())
+                .Set(x => x.SetByCtorNoPropertySetter, "0")
+                .Set(x => x.SetByCtorWithPrivateSetter, "1")
+                .Set(x => x.SetByCtorWithPublicSetter, "2")
+                .Set(x => x.NotSetByCtorWithPrivateSetter, "3")
+                .Set(x => x.NotSetByCtorWithPublicSetter, "4");
+
+            dto.SetByCtorNoPropertySetter.ShouldBe("0");
+            dto.SetByCtorWithPrivateSetter.ShouldBe("1");
+            dto.SetByCtorWithPublicSetter.ShouldBe("2");
+            dto.NotSetByCtorWithPrivateSetter.ShouldBe(null);
+            dto.NotSetByCtorWithPublicSetter.ShouldBe(null);
+        }
     }
 }

TestStack.Dossier.Tests/Factories/PublicPropertySettersFactoryTests.cs

@@ -8,15 +8,33 @@ namespace TestStack.Dossier.Tests.Factories
     public class PublicPropertySettersFactoryTests
     {
         [Fact]
-        public void GivenPublicPropertiesFactory_WhenBuilding_ThenOnlyConstructorAndPublicPropertiesSet()
+        public void GivenPublicPropertySettersFactory_WhenBuilding_ThenOnlyConstructorAndPublicPropertiesSet()
         {
             MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>.CreateNew(new PublicPropertySettersFactory());
 
             dto.SetByCtorNoPropertySetter.ShouldNotBe(null);
             dto.SetByCtorWithPrivateSetter.ShouldNotBe(null);
             dto.SetByCtorWithPublicSetter.ShouldNotBe(null);
+            dto.NotSetByCtorWithPrivateSetter.ShouldBe(null);
             dto.NotSetByCtorWithPublicSetter.ShouldNotBe(null);
+        }
+
+        [Fact]
+        public void GivenPublicPropertySettersFactoryAgainstBuilderWithModifications_WhenBuilding_ThenCustomisationsAreUsed()
+        {
+            MixedAccessibilityDto dto = Builder<MixedAccessibilityDto>
+                .CreateNew(new PublicPropertySettersFactory())
+                .Set(x => x.SetByCtorNoPropertySetter, "0")
+                .Set(x => x.SetByCtorWithPrivateSetter, "1")
+                .Set(x => x.SetByCtorWithPublicSetter, "2")
+                .Set(x => x.NotSetByCtorWithPrivateSetter, "3")
+                .Set(x => x.NotSetByCtorWithPublicSetter, "4");
+
+            dto.SetByCtorNoPropertySetter.ShouldBe("0");
+            dto.SetByCtorWithPrivateSetter.ShouldBe("1");
+            dto.SetByCtorWithPublicSetter.ShouldBe("2");
             dto.NotSetByCtorWithPrivateSetter.ShouldBe(null);
+            dto.NotSetByCtorWithPublicSetter.ShouldBe("4");
         }
     }
 }

TestStack.Dossier/Factories/AllPropertiesFactory.cs

@@ -3,16 +3,17 @@
 namespace TestStack.Dossier.Factories
 {
     /// <summary>
-    /// Creates an instance of an object by setting all public and private properties.
+    /// Builds the object using the constructor with the most arguments using values stored in the builder that match
+    ///   the constructor parameter name case insensitively and then sets all public and private property setters with
+    ///   values from the builder.
+    /// If there is no value specified in the builder for a ctor argument / property then the builder will supply an anonymous value.
     /// </summary>
-    public class AllPropertiesFactory : IFactory
+    public class AllPropertiesFactory : CallConstructorFactory
     {
         /// <inheritdoc />
-        public TObject BuildObject<TObject, TBuilder>(TestDataBuilder<TObject, TBuilder> builder)
-            where TObject : class
-            where TBuilder : TestDataBuilder<TObject, TBuilder>, new()
+        public override TObject BuildObject<TObject, TBuilder>(TestDataBuilder<TObject, TBuilder> builder)
         {
-            var model = builder.Any.Fixture.Create<TObject>();
+            var model = base.BuildObject(builder);
 
             var properties = Reflector.GetSettablePropertiesFor<TObject>();
             foreach (var property in properties)

TestStack.Dossier/Factories/PublicPropertySettersFactory.cs

@@ -3,7 +3,10 @@
 namespace TestStack.Dossier.Factories
 {
     /// <summary>
-    /// Creates an instance of an object by setting all public properties but not private properties.
+    /// Builds the object using the constructor with the most arguments using values stored in the builder that match
+    ///   the constructor parameter name case insensitively and then sets all public property setters with values from
+    ///   the builder.
+    /// If there is no value specified in the builder for a ctor argument / property then the builder will supply an anonymous value.
     /// </summary>
     public class PublicPropertySettersFactory : CallConstructorFactory
     {