Configuration cleanup #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There we go, configuration refactoring. Opinions?
It's fairly simple:
Each configuration has an own class, eg CoreConfiguration. It contains the configuration properties and the default values.
Then there's also a specific "Locator" (eg. CoreConfiguratioLocator). It provides an instance (always the same) of the configuration class. It can use a ConfigurationReader to fill the configuration class. By default it uses the App.config reader (AppConfigReader) to fill the values. A custom reader can be created and registered there if wanted.