Merge pull request #92 from senko-forks/pr-dyesplosion

Fix dye off by one error and CN exception

Author: Squall-Leonhart

xivModdingFramework/Materials/FileTypes/STM.cs

@@ -249,7 +249,7 @@ public StainingTemplateEntry(byte[] data, int offset, EStainingTemplate template
                     // No data.
                     continue;
                 }
-                else
+                else if (arraySize < numDyes)
                 {
                     // Indexed array, where we have [n] # of real entries,
                     // then 254 one-byte index entries referencing those [n] entries.
@@ -287,11 +287,13 @@ public StainingTemplateEntry(byte[] data, int offset, EStainingTemplate template
                 if(type == StainingTemplateArrayType.Indexed)
                 {
                     var nArray = new List<Half[]>();
-                    for (int i = 0; i < numDyes; i++)
+                    // The first entry in the list is an 0xFF byte that we skip
+                    // Since that would leave us with one less value than we need, as dummy value is added for the last dye
+                    for (int i = 1; i < numDyes + 1; i++)
                     {
                         try
                         {
-                            var index = data[indexStart + i];
+                            var index = (i == numDyes) ? 255 : data[indexStart + i];
                             if (index == 255 || index == 0)
                             {
                                 if (x < 3)
@@ -402,7 +404,7 @@ public StainingTemplateFile(byte[] data, EStainingTemplate templateType)
                 offset += oldFormat ? 2 : 4;
             }
 
-            const int _headerEntrySize = 8;
+            int _headerEntrySize = oldFormat ? 4 : 8;
             var endOfHeader = (8 + (_headerEntrySize * entryCount));
 
             for (int i = 0; i < entryCount; i++)