Fix dyes being off-by-one

helpful-fox-senko-san · helpful-fox-senko-san · commit dfdb3d27414e · 2025-05-11T05:43:05.000Z
diff --git a/xivModdingFramework/Materials/FileTypes/STM.cs b/xivModdingFramework/Materials/FileTypes/STM.cs
@@ -287,11 +287,13 @@ public StainingTemplateEntry(byte[] data, int offset, EStainingTemplate template
                 if(type == StainingTemplateArrayType.Indexed)
                 {
                     var nArray = new List<Half[]>();
-                    for (int i = 0; i < numDyes; i++)
+                    // The first entry in the list is an 0xFF byte that we skip
+                    // Since that would leave us with one less value than we need, as dummy value is added for the last dye
+                    for (int i = 1; i < numDyes + 1; i++)
                     {
                         try
                         {
-                            var index = data[indexStart + i];
+                            var index = (i == numDyes) ? 255 : data[indexStart + i];
                             if (index == 255 || index == 0)
                             {
                                 if (x < 3)

Original file line number	Diff line number	Diff line change
`@@ -287,11 +287,13 @@ public StainingTemplateEntry(byte[] data, int offset, EStainingTemplate template`
`287`	`287`	`if(type == StainingTemplateArrayType.Indexed)`
`288`	`288`	`{`
`289`	`289`	`var nArray = new List<Half[]>();`
`290`		`- for (int i = 0; i < numDyes; i++)`
	`290`	`+ // The first entry in the list is an 0xFF byte that we skip`
	`291`	`+ // Since that would leave us with one less value than we need, as dummy value is added for the last dye`
	`292`	`+ for (int i = 1; i < numDyes + 1; i++)`
`291`	`293`	`{`
`292`	`294`	`try`
`293`	`295`	`{`
`294`		`- var index = data[indexStart + i];`
	`296`	`+ var index = (i == numDyes) ? 255 : data[indexStart + i];`
`295`	`297`	`if (index == 255 \|\| index == 0)`
`296`	`298`	`{`
`297`	`299`	`if (x < 3)`