Skip to content

Add traditional chinese (TC), remove pre-7.2 CN/KR hacks #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: l10n
Choose a base branch
from
Open

Add traditional chinese (TC), remove pre-7.2 CN/KR hacks #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions xivModdingFramework/Cache/XivCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,11 +741,7 @@ private static async Task RebuildMountsCache(ModTransaction tx)
var _companions = new Companions();
var list = await _companions.GetUncachedMountList(tx);

// Don't get the ornament list for the Chinese or Korean clients as they don't have them yet
if (_gameInfo.GameLanguage != XivLanguage.Chinese && _gameInfo.GameLanguage != XivLanguage.Korean)
{
list.AddRange(await _companions.GetUncachedOrnamentList(tx));
}
list.AddRange(await _companions.GetUncachedOrnamentList(tx));

db.BusyTimeout = 3000;
db.Open();
Expand Down
1 change: 0 additions & 1 deletion xivModdingFramework/Exd/FileTypes/ExColumnExpectations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ internal static class ExColumnExpectations
if (language == XivLanguage.Korean)
{
// Set up overrides here if necessary for KR.
columnExpectations["Icon"] = (26, ExcelColumnDataType.UInt16);
}
else if (language == XivLanguage.Chinese)
{
Expand Down
1 change: 1 addition & 0 deletions xivModdingFramework/General/Enums/XivLanguage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ public enum XivLanguage
[Description("fr")] French,
[Description("ko")] Korean,
[Description("chs")] Chinese,
[Description("tc")] TraditionalChinese,
[Description("none")] None
}

Expand Down