Phase 9: Fix additional type checking errors

- Fixed type errors in trading_suite.py by using ProjectXBase consistently
- Fixed type errors in utils/task_management.py:
  - Changed _task_errors to accept BaseException instead of Exception
  - Fixed callable type hint to use proper Callable from typing
  - Fixed TimeoutError import (using builtin instead of asyncio.TimeoutError)
- Updated RealtimeDataManager to accept ProjectXBase | None for flexibility
- Updated RealtimeDataManagerProtocol to match implementation
- Fixed import sorting and formatting issues

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: TexasCoding

src/project_x_py/position_manager/core.py

@@ -74,6 +74,7 @@ async def main():
 from datetime import datetime
 from typing import TYPE_CHECKING, Any, Optional
 
+from project_x_py.client.base import ProjectXBase
 from project_x_py.models import Position
 from project_x_py.position_manager.analytics import PositionAnalyticsMixin
 from project_x_py.position_manager.monitoring import PositionMonitoringMixin
@@ -82,10 +83,7 @@ async def main():
 from project_x_py.position_manager.tracking import PositionTrackingMixin
 from project_x_py.risk_manager import RiskManager
 from project_x_py.types.config_types import PositionManagerConfig
-from project_x_py.types.protocols import (
-    ProjectXClientProtocol,
-    RealtimeDataManagerProtocol,
-)
+from project_x_py.types.protocols import RealtimeDataManagerProtocol
 from project_x_py.types.response_types import (
     PositionSizingResponse,
     RiskAnalysisResponse,
@@ -176,7 +174,7 @@ class PositionManager(
 
     def __init__(
         self,
-        project_x_client: "ProjectXClientProtocol",
+        project_x_client: "ProjectXBase",
         event_bus: Any,
         risk_manager: Optional["RiskManager"] = None,
         data_manager: Optional["RealtimeDataManagerProtocol"] = None,
@@ -228,7 +226,7 @@ def __init__(
         PositionMonitoringMixin.__init__(self)
         StatsTrackingMixin._init_stats_tracking(self)
 
-        self.project_x: ProjectXClientProtocol = project_x_client
+        self.project_x: ProjectXBase = project_x_client
         self.event_bus = event_bus  # Store the event bus for emitting events
         self.risk_manager = risk_manager
         self.data_manager = data_manager

src/project_x_py/position_manager/monitoring.py

@@ -60,7 +60,7 @@ async def on_alert(event):
 if TYPE_CHECKING:
     from asyncio import Lock
 
-    from project_x_py.types.protocols import ProjectXClientProtocol
+    from project_x_py.client.base import ProjectXBase
 
 logger = logging.getLogger(__name__)
 
@@ -77,7 +77,7 @@ class PositionMonitoringMixin:
         logger: logging.Logger
         stats: dict[str, Any]
         _realtime_enabled: bool
-        project_x: "ProjectXClientProtocol"
+        project_x: "ProjectXBase"
         data_manager: "RealtimeDataManagerProtocol | None"
 
         # Methods from other mixins/main class

src/project_x_py/realtime_data_manager/core.py

@@ -259,7 +259,7 @@ async def on_new_bar(data):
     def __init__(
         self,
         instrument: str,
-        project_x: "ProjectXBase",
+        project_x: "ProjectXBase | None",
         realtime_client: "ProjectXRealtimeClient",
         event_bus: Any | None = None,
         timeframes: list[str] | None = None,
@@ -338,7 +338,7 @@ def __init__(
 
         # Set basic attributes needed by mixins
         self.instrument: str = instrument
-        self.project_x: ProjectXBase = project_x
+        self.project_x: ProjectXBase | None = project_x
         self.realtime_client: ProjectXRealtimeClient = realtime_client
         # EventBus is optional in tests; fallback to a simple dummy if None
         self.event_bus = event_bus if event_bus is not None else _DummyEventBus()

src/project_x_py/types/protocols.py

@@ -354,7 +354,7 @@ async def close_position(
 class PositionManagerProtocol(Protocol):
     """Protocol defining the interface that mixins expect from PositionManager."""
 
-    project_x: "ProjectXClientProtocol"
+    project_x: "ProjectXBase"
     logger: Any
     event_bus: Any  # EventBus instance
     position_lock: asyncio.Lock
@@ -425,7 +425,7 @@ class RealtimeDataManagerProtocol(Protocol):
 
     # Core attributes
     instrument: str
-    project_x: "ProjectXBase"
+    project_x: "ProjectXBase | None"
     realtime_client: "ProjectXRealtimeClient"
     event_bus: Any  # EventBus instance
     logger: Any

src/project_x_py/utils/task_management.py

@@ -10,6 +10,7 @@
 
 import asyncio
 import logging
+from collections.abc import Callable
 from typing import TYPE_CHECKING, Any
 from weakref import WeakSet
 
@@ -47,7 +48,7 @@ def _init_task_manager(self) -> None:
         """Initialize task management attributes."""
         self._managed_tasks: WeakSet[Task[Any]] = WeakSet()
         self._persistent_tasks: set[Task[Any]] = set()  # Tasks that should not be GC'd
-        self._task_errors: list[Exception] = []
+        self._task_errors: list[BaseException] = []
         self._cleanup_in_progress = False
 
     def _create_task(
@@ -212,7 +213,9 @@ async def __aexit__(self, exc_type: Any, exc_val: Any, exc_tb: Any) -> None:
 
 
 def create_fire_and_forget_task(
-    coro: Any, name: str | None = None, error_handler: callable | None = None
+    coro: Any,
+    name: str | None = None,
+    error_handler: Callable[[BaseException], None] | None = None,
 ) -> "Task[Any]":
     """
     Create a fire-and-forget task with optional error handling.