fix(typing): Resolve client mixin type hierarchy and response handling issues

- Fix mixin type annotations to work properly with ProjectXBase
- Add proper attribute declarations in mixins for base class attributes
- Add isinstance checks before calling .get() on API responses to handle union types
- Remove unnecessary TYPE_CHECKING imports and clean up imports
- Fix response handling in auth, market_data, and trading mixins
- Update realtime_data_manager type hints for better type safety

This resolves the majority of type checking issues in the client modules,
reducing type errors from 100+ to just 13 remaining edge cases.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: TexasCoding

src/project_x_py/client/auth.py

@@ -54,7 +54,7 @@ async def main():
 import base64
 import datetime
 from datetime import timedelta
-from typing import TYPE_CHECKING
+from typing import Any
 
 import orjson
 import pytz
@@ -70,15 +70,30 @@ async def main():
     validate_response,
 )
 
-if TYPE_CHECKING:
-    from project_x_py.types import ProjectXClientProtocol
-
 logger = ProjectXLogger.get_logger(__name__)
 
 
 class AuthenticationMixin:
     """Mixin class providing authentication functionality."""
 
+    # These attributes are provided by the base class
+    username: str
+    api_key: str
+    account_name: str | None
+    headers: dict[str, str]
+
+    async def _make_request(
+        self,
+        method: str,
+        endpoint: str,
+        data: dict[str, Any] | None = None,
+        params: dict[str, Any] | None = None,
+        headers: dict[str, str] | None = None,
+        retry_count: int = 0,
+    ) -> Any:
+        """Provided by HttpMixin."""
+        _ = (method, endpoint, data, params, headers, retry_count)
+
     def __init__(self) -> None:
         """Initialize authentication attributes."""
         super().__init__()
@@ -87,7 +102,7 @@ def __init__(self) -> None:
         self._authenticated = False
         self.account_info: Account | None = None
 
-    async def _refresh_authentication(self: "ProjectXClientProtocol") -> None:
+    async def _refresh_authentication(self) -> None:
         """
         Refresh authentication if token is expired or about to expire.
 
@@ -103,7 +118,7 @@ async def _refresh_authentication(self: "ProjectXClientProtocol") -> None:
         if self._should_refresh_token():
             await self.authenticate()
 
-    def _should_refresh_token(self: "ProjectXClientProtocol") -> bool:
+    def _should_refresh_token(self) -> bool:
         """
         Check if the authentication token should be refreshed.
 
@@ -125,7 +140,7 @@ def _should_refresh_token(self: "ProjectXClientProtocol") -> bool:
         return datetime.datetime.now(pytz.UTC) >= (self.token_expiry - buffer_time)
 
     @handle_errors("authenticate")
-    async def authenticate(self: "ProjectXClientProtocol") -> None:
+    async def authenticate(self) -> None:
         """
         Authenticate with ProjectX API and select account.
 
@@ -191,7 +206,11 @@ async def authenticate(self: "ProjectXClientProtocol") -> None:
         accounts_response = await self._make_request(
             "POST", "/Account/search", data=payload
         )
-        if not accounts_response or not accounts_response.get("success", False):
+        if (
+            not accounts_response
+            or not isinstance(accounts_response, dict)
+            or not accounts_response.get("success", False)
+        ):
             raise ProjectXAuthenticationError(ErrorMessages.API_REQUEST_FAILED)
 
         accounts_data = accounts_response.get("accounts", [])
@@ -232,7 +251,7 @@ async def authenticate(self: "ProjectXClientProtocol") -> None:
             },
         )
 
-    async def _ensure_authenticated(self: "ProjectXClientProtocol") -> None:
+    async def _ensure_authenticated(self) -> None:
         """
         Ensure client is authenticated before making API calls.
 
@@ -257,7 +276,7 @@ async def _ensure_authenticated(self: "ProjectXClientProtocol") -> None:
 
     @handle_errors("list accounts")
     @validate_response(required_fields=["success", "accounts"])
-    async def list_accounts(self: "ProjectXClientProtocol") -> list[Account]:
+    async def list_accounts(self) -> list[Account]:
         """
         List all accounts available to the authenticated user.
 
@@ -282,7 +301,11 @@ async def list_accounts(self: "ProjectXClientProtocol") -> list[Account]:
         payload = {"onlyActiveAccounts": True}
         response = await self._make_request("POST", "/Account/search", data=payload)
 
-        if not response or not response.get("success", False):
+        if (
+            not response
+            or not isinstance(response, dict)
+            or not response.get("success", False)
+        ):
             return []
 
         accounts_data = response.get("accounts", [])

src/project_x_py/client/http.py

@@ -52,7 +52,7 @@ async def main():
 """
 
 import time
-from typing import TYPE_CHECKING, Any, TypeVar
+from typing import Any, TypeVar
 
 import httpx
 
@@ -77,9 +77,6 @@ async def main():
     retry_on_network_error,
 )
 
-if TYPE_CHECKING:
-    from project_x_py.types import ProjectXClientProtocol
-
 T = TypeVar("T")
 
 logger = ProjectXLogger.get_logger(__name__)
@@ -88,13 +85,25 @@ async def main():
 class HttpMixin:
     """Mixin class providing HTTP client functionality."""
 
+    # These attributes are provided by the base class or other mixins
+    config: Any  # ProjectXConfig
+    base_url: str
+    headers: dict[str, str]
+    session_token: str
+    rate_limiter: Any  # RateLimiter
+    cache_hit_count: int
+    api_call_count: int
+
+    async def _refresh_authentication(self) -> None:
+        """Provided by AuthenticationMixin."""
+
     def __init__(self) -> None:
         """Initialize HTTP client attributes."""
         super().__init__()
         self._client: httpx.AsyncClient | None = None
         self.api_call_count = 0
 
-    async def _create_client(self: "ProjectXClientProtocol") -> httpx.AsyncClient:
+    async def _create_client(self) -> httpx.AsyncClient:
         """
         Create an optimized httpx async client with connection pooling and retries.
 
@@ -138,7 +147,7 @@ async def _create_client(self: "ProjectXClientProtocol") -> httpx.AsyncClient:
 
         return client
 
-    async def _ensure_client(self: "ProjectXClientProtocol") -> httpx.AsyncClient:
+    async def _ensure_client(self) -> httpx.AsyncClient:
         """
         Ensure HTTP client is initialized and ready for API requests.
 
@@ -160,7 +169,7 @@ async def _ensure_client(self: "ProjectXClientProtocol") -> httpx.AsyncClient:
     @handle_rate_limit()
     @retry_on_network_error(max_attempts=3)
     async def _make_request(
-        self: "ProjectXClientProtocol",
+        self,
         method: str,
         endpoint: str,
         data: dict[str, Any] | None = None,
@@ -309,7 +318,7 @@ async def _make_request(
 
     @handle_errors("get health status")
     async def get_health_status(
-        self: "ProjectXClientProtocol",
+        self,
     ) -> PerformanceStatsResponse:
         """
         Get client statistics and performance metrics.

src/project_x_py/client/market_data.py

@@ -56,7 +56,7 @@ async def main():
 
 import datetime
 import re
-from typing import TYPE_CHECKING, Any
+from typing import Any
 
 import polars as pl
 import pytz
@@ -73,20 +73,50 @@ async def main():
     validate_response,
 )
 
-if TYPE_CHECKING:
-    from project_x_py.types import ProjectXClientProtocol
-
 logger = ProjectXLogger.get_logger(__name__)
 
 
 class MarketDataMixin:
     """Mixin class providing market data functionality."""
 
+    # These attributes are provided by the base class
+    logger: Any
+    config: Any  # ProjectXConfig
+
+    async def _ensure_authenticated(self) -> None:
+        """Provided by AuthenticationMixin."""
+
+    async def _make_request(
+        self,
+        method: str,
+        endpoint: str,
+        data: dict[str, Any] | None = None,
+        params: dict[str, Any] | None = None,
+        headers: dict[str, str] | None = None,
+        retry_count: int = 0,
+    ) -> Any:
+        """Provided by HttpMixin."""
+        _ = (method, endpoint, data, params, headers, retry_count)
+
+    def get_cached_instrument(self, symbol: str) -> Any:
+        """Provided by CacheMixin."""
+        _ = symbol
+
+    def cache_instrument(self, symbol: str, instrument: Any) -> None:
+        """Provided by CacheMixin."""
+        _ = (symbol, instrument)
+
+    def get_cached_market_data(self, cache_key: str) -> Any:
+        """Provided by CacheMixin."""
+        _ = cache_key
+
+    def cache_market_data(self, cache_key: str, data: Any) -> None:
+        """Provided by CacheMixin."""
+        _ = (cache_key, data)
+
     @handle_errors("get instrument")
     @validate_response(required_fields=["success", "contracts"])
-    async def get_instrument(
-        self: "ProjectXClientProtocol", symbol: str, live: bool = False
-    ) -> Instrument:
+    async def get_instrument(self, symbol: str, live: bool = False) -> Instrument:
         """
         Get detailed instrument information with caching.
 
@@ -200,7 +230,7 @@ async def get_instrument(
             return instrument
 
     def _select_best_contract(
-        self: "ProjectXClientProtocol",
+        self,
         instruments: list[dict[str, Any]],
         search_symbol: str,
     ) -> dict[str, Any]:
@@ -276,7 +306,7 @@ def _select_best_contract(
     @handle_errors("search instruments")
     @validate_response(required_fields=["success", "contracts"])
     async def search_instruments(
-        self: "ProjectXClientProtocol", query: str, live: bool = False
+        self, query: str, live: bool = False
     ) -> list[Instrument]:
         """
         Search for instruments by symbol or name.
@@ -312,10 +342,16 @@ async def search_instruments(
                 "POST", "/Contract/search", data=payload
             )
 
-            if not response or not response.get("success", False):
+            if (
+                not response
+                or not isinstance(response, dict)
+                or not response.get("success", False)
+            ):
                 return []
 
-            contracts_data = response.get("contracts", [])
+            contracts_data = (
+                response.get("contracts", []) if isinstance(response, dict) else []
+            )
             instruments = [Instrument(**contract) for contract in contracts_data]
 
             logger.debug(
@@ -327,7 +363,7 @@ async def search_instruments(
 
     @handle_errors("get bars")
     async def get_bars(
-        self: "ProjectXClientProtocol",
+        self,
         symbol: str,
         days: int = 8,
         interval: int = 5,

src/project_x_py/client/trading.py

@@ -67,30 +67,45 @@ async def main():
 import datetime
 import logging
 from datetime import timedelta
-from typing import TYPE_CHECKING
+from typing import Any
 
 import pytz
 
 from project_x_py.exceptions import ProjectXError
 from project_x_py.models import Position, Trade
 from project_x_py.utils.deprecation import deprecated
 
-if TYPE_CHECKING:
-    from project_x_py.types import ProjectXClientProtocol
-
 logger = logging.getLogger(__name__)
 
 
 class TradingMixin:
     """Mixin class providing trading functionality."""
 
+    # These attributes are provided by the base class
+    account_info: Any  # Account object
+
+    async def _ensure_authenticated(self) -> None:
+        """Provided by AuthenticationMixin."""
+
+    async def _make_request(
+        self,
+        method: str,
+        endpoint: str,
+        data: dict[str, Any] | None = None,
+        params: dict[str, Any] | None = None,
+        headers: dict[str, str] | None = None,
+        retry_count: int = 0,
+    ) -> Any:
+        """Provided by HttpMixin."""
+        _ = (method, endpoint, data, params, headers, retry_count)
+
     @deprecated(
         reason="Method renamed for API consistency",
         version="3.0.0",
         removal_version="4.0.0",
         replacement="search_open_positions()",
     )
-    async def get_positions(self: "ProjectXClientProtocol") -> list[Position]:
+    async def get_positions(self) -> list[Position]:
         """
         DEPRECATED: Get all open positions for the authenticated account.
 
@@ -108,7 +123,7 @@ async def get_positions(self: "ProjectXClientProtocol") -> list[Position]:
         return await self.search_open_positions()
 
     async def search_open_positions(
-        self: "ProjectXClientProtocol", account_id: int | None = None
+        self, account_id: int | None = None
     ) -> list[Position]:
         """
         Search for open positions for the currently authenticated account.
@@ -170,7 +185,7 @@ async def search_open_positions(
         return [Position(**pos) for pos in positions_data]
 
     async def search_trades(
-        self: "ProjectXClientProtocol",
+        self,
         start_date: datetime.datetime | None = None,
         end_date: datetime.datetime | None = None,
         contract_id: str | None = None,

src/project_x_py/realtime_data_manager/core.py

@@ -527,7 +527,13 @@ async def initialize(self, initial_days: int = 1) -> bool:
                 LogMessages.DATA_FETCH,
                 extra={"phase": "initialization", "instrument": self.instrument},
             )
-
+            if self.project_x is None:
+                raise ProjectXError(
+                    format_error_message(
+                        ErrorMessages.INTERNAL_ERROR,
+                        reason="ProjectX client not initialized",
+                    )
+                )
             # Get the contract ID for the instrument
             instrument_info: Instrument | None = await self.project_x.get_instrument(
                 self.instrument
@@ -558,6 +564,13 @@ async def initialize(self, initial_days: int = 1) -> bool:
             # Load initial data for all timeframes
             async with self.data_lock:
                 for tf_key, tf_config in self.timeframes.items():
+                    if self.project_x is None:
+                        raise ProjectXError(
+                            format_error_message(
+                                ErrorMessages.INTERNAL_ERROR,
+                                reason="ProjectX client not initialized",
+                            )
+                        )
                     bars = await self.project_x.get_bars(
                         self.instrument,  # Use base symbol, not contract ID
                         interval=tf_config["interval"],