-
Notifications
You must be signed in to change notification settings - Fork 78
docs(u-boot): AM335X: Update splash screen details for 09.03.05.02 #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(u-boot): AM335X: Update splash screen details for 09.03.05.02 #116
Conversation
|
@devarsht , @jainswamil please review |
074b933 to
0cbc0f5
Compare
source/linux/Foundational_Components/U-Boot/Apps-Splash-Screen.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/U-Boot/Apps-Splash-Screen.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/U-Boot/Apps-Splash-Screen.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/U-Boot/Apps-Splash-Screen.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/U-Boot/Apps-Splash-Screen.rst
Outdated
Show resolved
Hide resolved
|
@sukrutb please update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please plan to use ref and cross reference this section under AM335x release notes.
Checkout following links for more details,
How to use ref - https://www.sphinx-doc.org/en/master/usage/referencing.html#cross-referencing-arbitrary-locations
Link to AM335X release notes - https://github.com/TexasInstruments/processor-sdk-doc/blob/master/source/devices/AM335X/linux/Release_Specific_Release_Notes.rst?plain=1#L60
devarsht
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ain't it more apt to use UG-Splash screen i.e. below instead of APP-Splash-screen, For all Sitara platforms we use UG-Splash screen so that guide is more evolved.
https://github.com/TexasInstruments/processor-sdk-doc/blob/0cbc0f59f3aea10940952042012043c21c232fc7/source/linux/Foundational_Components/U-Boot/UG-Splash-Screen.rst
|
cshilwant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sukrutb I still don't see this as well as other references of code section indentation under code-blocks being fixed - https://github.com/TexasInstruments/processor-sdk-doc/pull/116/files#r1887764585
The UG-Splash-screen.rst is not specific to AM62x, other SoCs like AM62p too use the same guide. I am not sure about the goal for app-splash-screen.rst need to check with Bin on this. |
devarsht
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sukrutb , anything to add from perspective of flicker-free transition solution ? I remember you did some enablement using pwm preservation and some discussions were there with simple-framebuffer too ?
|
@sukrutb I see many unrelated commits. Can you rebase and ensure only intended commits are in your PR |
3a25f5e to
73b6f6e
Compare
@cshilwant , Done. |
Author has updated the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sukrutb I still see 5 commits on this PR.
I believe you used the Github's apply suggestion feature?
Apparently that's not encouraged. Author's are expected to resolve comments from reviewers manually.
The Github's apply suggestion feature messes with the Signed-off-by tags
FYR, I see below in 1286639
Signed-off-by: Sukrut Bellary <[email protected]>Update the splash screen details with defconfig changes to enable the splash screen with backlight. Add steps to test the splash screen. Add the reference output image on AM335x EVM. Signed-off-by: Sukrut Bellary <[email protected]>
73b6f6e to
8d9b282
Compare
@cshilwant , fixed. Please review. Thanks. |
|
@praneethbajjuri @StaticRocket @devarsht for re-review |
Update splash screen details with defconfig changes to enable splash screen.
Add steps to test the splash screen.
Add the reference output image on AM335x EVM.