Update HSR_Offload.rst#160
Conversation
Kathryn Kalouf - PME supporting AM64/AM243 with Sitara. Updating the introduction and supported features. Signed-off-by: kathrynsuraya <k-kalouf@ti.com>
kathrynsuraya
requested review from
StaticRocket,
VeeruPrudhvi,
aniket-l,
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
github-actions
bot
assigned
devarsht,
praneethbajjuri,
r-vignesh,
Siddharth-Vadapalli-at-TI and
uditkumarti
There was a problem hiding this comment.
Commit message doesn’t follow guidelines set for the repository - https://github.com/TexasInstruments/processor-sdk-doc/actions/runs/13251783367?pr=160
Refer https://github.com/TexasInstruments/processor-sdk-doc/blob/master/CONTRIBUTING.md#commit-formatting
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/HSR_Offload.rst
Outdated
Show resolved
Hide resolved
…work/HSR_Offload.rst Co-authored-by: Chirag Shilwant <115738422+cshilwant@users.noreply.github.com> Signed-off-by: kathrynsuraya <k-kalouf@ti.com>
|
This is my first time doing this. In order to change the commit message, what would be the next steps? Do i submit another pull request? And is this all that needs to be resolved? |
|
@kathrynsuraya You can use the same PR and I see two commits in this PR now. Can you also make it into a single commit with updated commit message |
StaticRocket
left a comment
StaticRocket
left a comment
There was a problem hiding this comment.
Otherwise, this seems fine. Please squash your commits and change the subject to follow conventionalcommits (just change it to something like "feat: describe pru issg offloading")
|
|
||
| HSR framework in Linux allows offloading below functionalities to the device: | ||
|
|
||
| • hsr-fwd-offload: For forwarding HSR frames one port to another i.e. port-to-port forwarding |
There was a problem hiding this comment.
| • hsr-fwd-offload: For forwarding HSR frames one port to another i.e. port-to-port forwarding | |
| - hsr-fwd-offload: For forwarding HSR frames one port to another i.e. port-to-port forwarding |
Simply using a - for list items creates a sphinx list, which adjusts formatting automatically based on the output document.
https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#lists-and-quote-like-blocks
|
@kathrynsuraya address the review comments and push the update on this pr. |
|
@praneethbajjuri Hi, because I am not familiar with github, I would have to download git to my computer to do this. I was hoping I could be able to do this on the web. This will take me some time. |
|
marking as closed. submitter will send a new PR later. |
8 participants
Kathryn Kalouf - PME supporting AM64/AM243 with Sitara. Updating the introduction and supported features.