Document TX Checksum Offload and Zero-Checksum Inversion #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siddharth-Vadapalli-at-TI
requested review from
StaticRocket,
VeeruPrudhvi,
aniket-l,
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
github-actions
bot
assigned
devarsht,
praneethbajjuri,
r-vignesh,
Siddharth-Vadapalli-at-TI and
uditkumarti
Siddharth-Vadapalli-at-TI
force-pushed
the
cpsw-zero-checksum-inversion
branch
2 times, most recently
from
ebe2395 to
44541ee
Compare
cshilwant
requested changes
Feb 13, 2025
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/_K3-CPSW-common.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/_K3-CPSW-common.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/_K3-CPSW-common.rst
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@cshilwant, thank you for reviewing the PR. I missed updating the code-blocks that you pointed out. I will also change |
Siddharth-Vadapalli-at-TI
force-pushed
the
cpsw-zero-checksum-inversion
branch
from
44541ee to
2db0bfe
Compare
Collaborator
Author
|
@cshilwant, I have updated the PR implemented your feedback. |
cshilwant
previously approved these changes
Feb 14, 2025
StaticRocket
previously requested changes
Feb 15, 2025
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/_K3-CPSW-common.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/_K3-CPSW-common.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/_K3-CPSW-common.rst
Outdated
Show resolved
Hide resolved
Use the standard "3 space" indentation and update the code-block "::" sections indicating that they are belong to the "console" format. Signed-off-by: Siddharth Vadapalli <[email protected]>
Add a section documenting the TX Checksum offload feature along with details on the changes to be made in the am65-cpsw-nuss.c driver for inverting a checksum of zero. Signed-off-by: Siddharth Vadapalli <[email protected]>
Siddharth-Vadapalli-at-TI
force-pushed
the
cpsw-zero-checksum-inversion
branch
from
2db0bfe to
c57af8a
Compare
Collaborator
Author
|
@StaticRocket, I have updated the PR implementing your feedback. |
jeevantelukula
approved these changes
Feb 17, 2025
cshilwant
approved these changes
Feb 17, 2025
Member
|
+ @StaticRocket to finally review based on his feedback |
StaticRocket
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.