Kernel: Kernel_Drivers:Display: Device Tree Node: Added comments about necessity of HPD pin for J721S2 #2
Conversation
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Display/DSS7.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Display/DSS7.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Display/DSS7.rst
Outdated
Show resolved
Hide resolved
StaticRocket
left a comment
StaticRocket
left a comment
There was a problem hiding this comment.
This new commit just adds actual whitespace errors. There needs the be a new line separating a directive from it's content and a newline to end a content block.
Having any whitespace on either of these lines confuses the parser as to what is content and what the end of the content block is.
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Display/DSS7.rst
Outdated
Show resolved
Hide resolved
|
|
||
| .. ifconfig:: CONFIG_part_variant in ('J721S2') | ||
|
|
||
| - Pin designated as HPD for DP should not be used for other purpose, irrespective of whether it is connected as HPD or not. |
There was a problem hiding this comment.
is this covered in TRM? if so, point out chapter. DO NOT make s/w SDK documentation the goto place for careabouts of the SoC.
There was a problem hiding this comment.
@h-shenoy could you verify this and resolve this conversation if it is actually covered in the TRM?
There was a problem hiding this comment.
No, I did not find information regarding HPD pin connection status in TRM , let me know if information regarding the can be made part of SDK ?
There was a problem hiding this comment.
ideally, you wont document SoC features in S/w documentation - you should file a internal ticket asking it to be documented in TRM and discuss with applications team how to handle it best.
There was a problem hiding this comment.
@uditkumarti , should this be documented in TRM and not in SDK docs as mentioned in ticket?
There was a problem hiding this comment.
needs to be part of TRM . Please reject this PR
cshilwant
left a comment
cshilwant
left a comment
There was a problem hiding this comment.
Rebase your PR on master for checkers to start their job
…t necessity of HPD pin for J721S2 Signed-off-by: Harikrishna Shenoy <[email protected]>
StaticRocket
left a comment
StaticRocket
left a comment
There was a problem hiding this comment.
Please update in accordance with contribution guidelines
# This is the 1st commit message: Update TI_Apps_Launcher_User_Guide.rst Switched images on the guide to accurately depict the device Signed-off-by: riyaaysola <[email protected]> # This is the commit message TexasInstruments#2: Update source/linux/Demo_User_Guides/TI_Apps_Launcher_User_Guide.rst Co-authored-by: Randolph Sapp <[email protected]> Signed-off-by: riyaaysola <[email protected]>
5 participants
Add comments about necessity of HPD pin for J721S2.